cerc-io/plugeth
18
0
Fork 1
Code Issues 4 Pull Requests Packages Projects Releases Wiki Activity

common/hexutil: fix EncodeBig, Big.MarshalJSON

Browse Source 
The code was too clever and failed to include zeros on a big.Word
boundary.
This commit is contained in:
Felix Lange 2017-01-16 10:20:20 +01:00
parent 01f6f2d741
commit 51f6b6d33f
3 changed files with 4 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
common/hexutil/hexutil.go
View File

@ -169,12 +169,7 @@ func EncodeBig(bigint *big.Int) string {
if nbits == 0 { if nbits == 0 {
return "0x0" return "0x0"
} }
enc := make([]byte, 2, (nbits/8)*2+2) return fmt.Sprintf("0x%x", bigint)
copy(enc, "0x")
for i := len(bigint.Bits()) - 1; i >= 0; i-- {
enc = strconv.AppendUint(enc, uint64(bigint.Bits()[i]), 16)
}
return string(enc)
} }
func has0xPrefix(input string) bool { func has0xPrefix(input string) bool {

1
common/hexutil/hexutil_test.go
View File

@ -46,6 +46,7 @@ var (
{referenceBig("1"), "0x1"}, {referenceBig("1"), "0x1"},
{referenceBig("ff"), "0xff"}, {referenceBig("ff"), "0xff"},
{referenceBig("112233445566778899aabbccddeeff"), "0x112233445566778899aabbccddeeff"}, {referenceBig("112233445566778899aabbccddeeff"), "0x112233445566778899aabbccddeeff"},
{referenceBig("80a7f2c1bcc396c00"), "0x80a7f2c1bcc396c00"},
} }
encodeUint64Tests = []marshalTest{ encodeUint64Tests = []marshalTest{

9
common/hexutil/json.go
View File

@ -109,13 +109,8 @@ func (b *Big) MarshalJSON() ([]byte, error) {
if nbits == 0 { if nbits == 0 {
return jsonZero, nil return jsonZero, nil
} }
enc := make([]byte, 3, (nbits/8)*2+4) enc := fmt.Sprintf(`"0x%x"`, bigint)
copy(enc, `"0x`) return []byte(enc), nil
for i := len(bigint.Bits()) - 1; i >= 0; i-- {
enc = strconv.AppendUint(enc, uint64(bigint.Bits()[i]), 16)
}
enc = append(enc, '"')
return enc, nil
} }
// UnmarshalJSON implements json.Unmarshaler. // UnmarshalJSON implements json.Unmarshaler.