common/bitutil: use result of TestBytes to prevent dead code elimination (#19846)
Gollvm has very aggressive dead code elimination that completely removes one of these two benchmarks. To prevent this, use the result of the benchmark (a boolean), and to be "fair", make the transformation to both benchmarks. To be reliably assured of not removing the code, "use" means assigning to an exported global. Non-exported globals and //go:noinline functions are possibly subject to this optimization.
This commit is contained in:
parent
6bd896a97f
commit
31a1f164d9
@ -190,6 +190,8 @@ func benchmarkBaseOR(b *testing.B, size int) {
|
||||
}
|
||||
}
|
||||
|
||||
var GloBool bool // Exported global will not be dead-code eliminated, at least not yet.
|
||||
|
||||
// Benchmarks the potentially optimized bit testing performance.
|
||||
func BenchmarkFastTest1KB(b *testing.B) { benchmarkFastTest(b, 1024) }
|
||||
func BenchmarkFastTest2KB(b *testing.B) { benchmarkFastTest(b, 2048) }
|
||||
@ -197,9 +199,11 @@ func BenchmarkFastTest4KB(b *testing.B) { benchmarkFastTest(b, 4096) }
|
||||
|
||||
func benchmarkFastTest(b *testing.B, size int) {
|
||||
p := make([]byte, size)
|
||||
a := false
|
||||
for i := 0; i < b.N; i++ {
|
||||
TestBytes(p)
|
||||
a = a != TestBytes(p)
|
||||
}
|
||||
GloBool = a // Use of benchmark "result" to prevent total dead code elimination.
|
||||
}
|
||||
|
||||
// Benchmarks the baseline bit testing performance.
|
||||
@ -209,7 +213,9 @@ func BenchmarkBaseTest4KB(b *testing.B) { benchmarkBaseTest(b, 4096) }
|
||||
|
||||
func benchmarkBaseTest(b *testing.B, size int) {
|
||||
p := make([]byte, size)
|
||||
a := false
|
||||
for i := 0; i < b.N; i++ {
|
||||
safeTestBytes(p)
|
||||
a = a != safeTestBytes(p)
|
||||
}
|
||||
GloBool = a // Use of benchmark "result" to prevent total dead code elimination.
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user