2015-07-07 00:54:22 +00:00
|
|
|
// Copyright 2014 The go-ethereum Authors
|
2015-07-22 16:48:40 +00:00
|
|
|
// This file is part of the go-ethereum library.
|
2015-07-07 00:54:22 +00:00
|
|
|
//
|
2015-07-23 16:35:11 +00:00
|
|
|
// The go-ethereum library is free software: you can redistribute it and/or modify
|
2015-07-07 00:54:22 +00:00
|
|
|
// it under the terms of the GNU Lesser General Public License as published by
|
|
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
|
|
// (at your option) any later version.
|
|
|
|
//
|
2015-07-22 16:48:40 +00:00
|
|
|
// The go-ethereum library is distributed in the hope that it will be useful,
|
2015-07-07 00:54:22 +00:00
|
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
2015-07-22 16:48:40 +00:00
|
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
2015-07-07 00:54:22 +00:00
|
|
|
// GNU Lesser General Public License for more details.
|
|
|
|
//
|
|
|
|
// You should have received a copy of the GNU Lesser General Public License
|
2015-07-22 16:48:40 +00:00
|
|
|
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
|
2015-07-07 00:54:22 +00:00
|
|
|
|
2015-07-07 03:08:16 +00:00
|
|
|
// Package miner implements Ethereum block creation and mining.
|
2014-10-31 13:56:42 +00:00
|
|
|
package miner
|
|
|
|
|
|
|
|
import (
|
2015-08-07 10:12:05 +00:00
|
|
|
"fmt"
|
2019-04-23 07:08:51 +00:00
|
|
|
"math/big"
|
2021-10-08 16:36:58 +00:00
|
|
|
"sync"
|
2018-08-21 19:56:54 +00:00
|
|
|
"time"
|
2014-10-31 13:56:42 +00:00
|
|
|
|
2015-03-18 12:00:01 +00:00
|
|
|
"github.com/ethereum/go-ethereum/common"
|
2019-04-23 07:08:51 +00:00
|
|
|
"github.com/ethereum/go-ethereum/common/hexutil"
|
2017-04-04 22:16:29 +00:00
|
|
|
"github.com/ethereum/go-ethereum/consensus"
|
2015-02-17 11:24:51 +00:00
|
|
|
"github.com/ethereum/go-ethereum/core"
|
2015-04-07 10:32:55 +00:00
|
|
|
"github.com/ethereum/go-ethereum/core/state"
|
2022-10-24 13:13:55 +00:00
|
|
|
"github.com/ethereum/go-ethereum/core/txpool"
|
2015-04-07 10:32:55 +00:00
|
|
|
"github.com/ethereum/go-ethereum/core/types"
|
2015-05-14 22:43:00 +00:00
|
|
|
"github.com/ethereum/go-ethereum/eth/downloader"
|
|
|
|
"github.com/ethereum/go-ethereum/event"
|
2017-02-22 12:10:07 +00:00
|
|
|
"github.com/ethereum/go-ethereum/log"
|
2015-08-07 10:12:05 +00:00
|
|
|
"github.com/ethereum/go-ethereum/params"
|
2014-10-31 13:56:42 +00:00
|
|
|
)
|
|
|
|
|
2022-01-24 07:19:52 +00:00
|
|
|
// Backend wraps all methods required for mining. Only full node is capable
|
|
|
|
// to offer all the functions here.
|
2016-08-15 18:14:05 +00:00
|
|
|
type Backend interface {
|
|
|
|
BlockChain() *core.BlockChain
|
2022-10-24 13:13:55 +00:00
|
|
|
TxPool() *txpool.TxPool
|
2016-08-15 18:14:05 +00:00
|
|
|
}
|
|
|
|
|
2019-04-23 07:08:51 +00:00
|
|
|
// Config is the configuration parameters of mining.
|
|
|
|
type Config struct {
|
2023-05-03 09:58:39 +00:00
|
|
|
Etherbase common.Address `toml:",omitempty"` // Public address for block mining rewards
|
|
|
|
ExtraData hexutil.Bytes `toml:",omitempty"` // Block extra data set by the miner
|
|
|
|
GasFloor uint64 // Target gas floor for mined blocks.
|
|
|
|
GasCeil uint64 // Target gas ceiling for mined blocks.
|
|
|
|
GasPrice *big.Int // Minimum gas price for mining a transaction
|
|
|
|
Recommit time.Duration // The time interval for miner to re-create mining work.
|
2022-10-03 12:10:00 +00:00
|
|
|
|
|
|
|
NewPayloadTimeout time.Duration // The maximum time allowance for creating a new payload
|
|
|
|
}
|
|
|
|
|
|
|
|
// DefaultConfig contains default settings for miner.
|
|
|
|
var DefaultConfig = Config{
|
2022-11-03 14:18:28 +00:00
|
|
|
GasCeil: 30000000,
|
|
|
|
GasPrice: big.NewInt(params.GWei),
|
|
|
|
|
|
|
|
// The default recommit time is chosen as two seconds since
|
|
|
|
// consensus-layer usually will wait a half slot of time(6s)
|
|
|
|
// for payload generation. It should be enough for Geth to
|
|
|
|
// run 3 rounds.
|
|
|
|
Recommit: 2 * time.Second,
|
2022-10-03 12:10:00 +00:00
|
|
|
NewPayloadTimeout: 2 * time.Second,
|
2019-04-23 07:08:51 +00:00
|
|
|
}
|
|
|
|
|
2016-08-15 18:14:05 +00:00
|
|
|
// Miner creates blocks and searches for proof-of-work values.
|
2014-10-31 13:56:42 +00:00
|
|
|
type Miner struct {
|
2023-01-20 16:26:01 +00:00
|
|
|
mux *event.TypeMux
|
|
|
|
eth Backend
|
|
|
|
engine consensus.Engine
|
|
|
|
exitCh chan struct{}
|
|
|
|
startCh chan struct{}
|
|
|
|
stopCh chan struct{}
|
|
|
|
worker *worker
|
2021-10-08 16:36:58 +00:00
|
|
|
|
|
|
|
wg sync.WaitGroup
|
2014-11-07 11:18:48 +00:00
|
|
|
}
|
|
|
|
|
2022-01-24 07:19:52 +00:00
|
|
|
func New(eth Backend, config *Config, chainConfig *params.ChainConfig, mux *event.TypeMux, engine consensus.Engine, isLocalBlock func(header *types.Header) bool) *Miner {
|
2016-08-15 18:14:05 +00:00
|
|
|
miner := &Miner{
|
2020-09-10 17:27:42 +00:00
|
|
|
mux: mux,
|
2023-01-20 16:26:01 +00:00
|
|
|
eth: eth,
|
2020-09-10 17:27:42 +00:00
|
|
|
engine: engine,
|
|
|
|
exitCh: make(chan struct{}),
|
2023-01-20 16:26:01 +00:00
|
|
|
startCh: make(chan struct{}),
|
2020-09-10 17:27:42 +00:00
|
|
|
stopCh: make(chan struct{}),
|
2022-01-24 07:19:52 +00:00
|
|
|
worker: newWorker(config, chainConfig, engine, eth, mux, isLocalBlock, true),
|
2016-08-15 18:14:05 +00:00
|
|
|
}
|
2021-10-08 16:36:58 +00:00
|
|
|
miner.wg.Add(1)
|
2015-05-14 22:43:00 +00:00
|
|
|
go miner.update()
|
|
|
|
return miner
|
2014-10-31 13:56:42 +00:00
|
|
|
}
|
|
|
|
|
2015-05-21 09:57:00 +00:00
|
|
|
// update keeps track of the downloader events. Please be aware that this is a one shot type of update loop.
|
|
|
|
// It's entered once and as soon as `Done` or `Failed` has been broadcasted the events are unregistered and
|
|
|
|
// the loop is exited. This to prevent a major security vuln where external parties can DOS you with blocks
|
|
|
|
// and halt your mining operation for as long as the DOS continues.
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) update() {
|
2021-10-08 16:36:58 +00:00
|
|
|
defer miner.wg.Done()
|
|
|
|
|
2019-11-24 19:46:34 +00:00
|
|
|
events := miner.mux.Subscribe(downloader.StartEvent{}, downloader.DoneEvent{}, downloader.FailedEvent{})
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
defer func() {
|
|
|
|
if !events.Closed() {
|
|
|
|
events.Unsubscribe()
|
|
|
|
}
|
|
|
|
}()
|
2015-05-14 22:43:00 +00:00
|
|
|
|
2020-09-10 17:27:42 +00:00
|
|
|
shouldStart := false
|
2020-09-11 16:17:09 +00:00
|
|
|
canStart := true
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
dlEventCh := events.Chan()
|
2018-08-14 15:34:33 +00:00
|
|
|
for {
|
|
|
|
select {
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
case ev := <-dlEventCh:
|
2018-08-14 15:34:33 +00:00
|
|
|
if ev == nil {
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
// Unsubscription done, stop listening
|
|
|
|
dlEventCh = nil
|
|
|
|
continue
|
2018-08-14 15:34:33 +00:00
|
|
|
}
|
|
|
|
switch ev.Data.(type) {
|
|
|
|
case downloader.StartEvent:
|
2020-09-10 17:27:42 +00:00
|
|
|
wasMining := miner.Mining()
|
|
|
|
miner.worker.stop()
|
2020-09-11 16:17:09 +00:00
|
|
|
canStart = false
|
2020-09-10 17:27:42 +00:00
|
|
|
if wasMining {
|
|
|
|
// Resume mining after sync was finished
|
|
|
|
shouldStart = true
|
2018-08-14 15:34:33 +00:00
|
|
|
log.Info("Mining aborted due to sync")
|
|
|
|
}
|
2023-05-31 07:09:49 +00:00
|
|
|
miner.worker.syncing.Store(true)
|
|
|
|
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
case downloader.FailedEvent:
|
|
|
|
canStart = true
|
|
|
|
if shouldStart {
|
|
|
|
miner.worker.start()
|
|
|
|
}
|
2023-05-31 07:09:49 +00:00
|
|
|
miner.worker.syncing.Store(false)
|
|
|
|
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
case downloader.DoneEvent:
|
2020-09-11 16:17:09 +00:00
|
|
|
canStart = true
|
2018-08-14 15:34:33 +00:00
|
|
|
if shouldStart {
|
2020-09-10 17:27:42 +00:00
|
|
|
miner.worker.start()
|
2018-08-14 15:34:33 +00:00
|
|
|
}
|
2023-05-31 07:09:49 +00:00
|
|
|
miner.worker.syncing.Store(false)
|
|
|
|
|
miner: don't interrupt mining after successful sync (#21701)
* miner: exit loop when downloader Done or Failed
Following the logic of the comment at the method,
this fixes a regression introduced at 7cf56d6f064869cb62b1673f9ee437020c595391
, which would allow external parties to DoS with
blocks, preventing mining progress.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove ineff assign (lint)
Signed-off-by: meows <b5c6@protonmail.com>
* miner: update test re downloader events
Signed-off-by: meows <b5c6@protonmail.com>
* Revert "miner: remove ineff assign (lint)"
This reverts commit eaefcd34ab4862ebc936fb8a07578aa2744bc058.
* Revert "miner: exit loop when downloader Done or Failed"
This reverts commit 23abd34265aa246c38fc390bb72572ad6ae9fe3b.
* miner: add test showing imprecise TestMiner
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix waitForMiningState precision
This helper function would return an affirmation
on the first positive match on a desired bool.
This was imprecise; it return false positives
by not waiting initially for an 'updated' value.
This fix causes TestMiner_2 to fail, which is
expected.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: remove TestMiner_2 demonstrating broken test
This test demonstrated the imprecision of the test
helper function waitForMiningState. This function
has been fixed with 6d365c2851, and this test test
may now be removed.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix test regarding downloader event/mining expectations
See comment for logic.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: add test describing expectations for downloader/mining events
We expect that once the downloader emits a DoneEvent,
signaling a successful sync, that subsequent StartEvents
are not longer permitted to stop the miner.
This prevents a security vulnerability where forced syncs via
fake high blocks would stall mining operation.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: use 'canStop' state to fix downloader event handling
- Break downloader event handling into event
separating Done and Failed events. We need to
treat these cases differently since a DoneEvent
should prevent the miner from being stopped on
subsequent downloader Start events.
- Use canStop state to handle the one-off
case when a downloader first succeeds.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: improve comment wording
Signed-off-by: meows <b5c6@protonmail.com>
* miner: start mining on downloader events iff not already mining
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor miner update logic w/r/t downloader events
This makes mining pause/start logic regarding downloader
events more explicit. Instead of eternally handling downloader
events after the first done event, the subscription is closed
when downloader events are no longer actionable.
Signed-off-by: meows <b5c6@protonmail.com>
* miner: fix handling downloader events on subcription closed
Signed-off-by: meows <b5c6@protonmail.com>
* miner: (lint:gosimple) use range over chan instead of for/select
Signed-off-by: meows <b5c6@protonmail.com>
* miner: refactor update loop to remove race condition
The go routine handling the downloader events handling
vars in parallel with the parent routine, causing a
race condition.
This change, though ugly, remove the condition while
still allowing the downloader event subscription to be
closed when the miner has no further use for it (ie DoneEvent).
* miner: alternate fix for miner-flaw
Co-authored-by: meows <b5c6@protonmail.com>
2020-10-13 12:12:06 +00:00
|
|
|
// Stop reacting to downloader events
|
|
|
|
events.Unsubscribe()
|
2015-05-14 22:43:00 +00:00
|
|
|
}
|
2023-01-20 16:26:01 +00:00
|
|
|
case <-miner.startCh:
|
2020-09-11 16:17:09 +00:00
|
|
|
if canStart {
|
|
|
|
miner.worker.start()
|
|
|
|
}
|
|
|
|
shouldStart = true
|
2020-09-10 17:27:42 +00:00
|
|
|
case <-miner.stopCh:
|
2020-09-11 16:17:09 +00:00
|
|
|
shouldStart = false
|
2020-09-10 17:27:42 +00:00
|
|
|
miner.worker.stop()
|
2019-11-24 19:46:34 +00:00
|
|
|
case <-miner.exitCh:
|
2020-09-10 17:27:42 +00:00
|
|
|
miner.worker.close()
|
2018-08-14 15:34:33 +00:00
|
|
|
return
|
2015-05-14 22:43:00 +00:00
|
|
|
}
|
|
|
|
}
|
2015-05-09 10:04:00 +00:00
|
|
|
}
|
|
|
|
|
2023-01-20 16:26:01 +00:00
|
|
|
func (miner *Miner) Start() {
|
|
|
|
miner.startCh <- struct{}{}
|
2014-10-31 13:56:42 +00:00
|
|
|
}
|
2014-11-07 11:18:48 +00:00
|
|
|
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) Stop() {
|
2020-09-10 17:27:42 +00:00
|
|
|
miner.stopCh <- struct{}{}
|
2015-05-11 13:43:14 +00:00
|
|
|
}
|
|
|
|
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) Close() {
|
|
|
|
close(miner.exitCh)
|
2021-10-08 16:36:58 +00:00
|
|
|
miner.wg.Wait()
|
2015-10-29 12:28:00 +00:00
|
|
|
}
|
|
|
|
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) Mining() bool {
|
|
|
|
return miner.worker.isRunning()
|
2015-05-14 22:43:00 +00:00
|
|
|
}
|
|
|
|
|
2021-03-31 07:56:51 +00:00
|
|
|
func (miner *Miner) Hashrate() uint64 {
|
2019-11-24 19:46:34 +00:00
|
|
|
if pow, ok := miner.engine.(consensus.PoW); ok {
|
2018-08-03 08:33:37 +00:00
|
|
|
return uint64(pow.Hashrate())
|
2015-08-06 09:58:14 +00:00
|
|
|
}
|
2018-08-03 08:33:37 +00:00
|
|
|
return 0
|
2014-11-07 11:18:48 +00:00
|
|
|
}
|
2015-04-05 16:57:03 +00:00
|
|
|
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) SetExtra(extra []byte) error {
|
2017-01-04 19:17:24 +00:00
|
|
|
if uint64(len(extra)) > params.MaximumExtraDataSize {
|
2019-11-24 19:46:34 +00:00
|
|
|
return fmt.Errorf("extra exceeds max length. %d > %v", len(extra), params.MaximumExtraDataSize)
|
2015-08-07 10:12:05 +00:00
|
|
|
}
|
2019-11-24 19:46:34 +00:00
|
|
|
miner.worker.setExtra(extra)
|
2015-08-07 10:12:05 +00:00
|
|
|
return nil
|
2015-04-05 16:57:03 +00:00
|
|
|
}
|
2015-04-07 10:32:55 +00:00
|
|
|
|
2024-02-06 08:59:24 +00:00
|
|
|
func (miner *Miner) SetGasTip(tip *big.Int) error {
|
|
|
|
miner.worker.setGasTip(tip)
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2018-08-21 19:56:54 +00:00
|
|
|
// SetRecommitInterval sets the interval for sealing work resubmitting.
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) SetRecommitInterval(interval time.Duration) {
|
|
|
|
miner.worker.setRecommitInterval(interval)
|
2018-08-21 19:56:54 +00:00
|
|
|
}
|
|
|
|
|
2023-05-31 07:09:49 +00:00
|
|
|
// Pending returns the currently pending block and associated state. The returned
|
|
|
|
// values can be nil in case the pending block is not initialized
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) Pending() (*types.Block, *state.StateDB) {
|
|
|
|
return miner.worker.pending()
|
2015-04-07 10:32:55 +00:00
|
|
|
}
|
2015-07-07 08:58:47 +00:00
|
|
|
|
2023-05-31 07:09:49 +00:00
|
|
|
// PendingBlock returns the currently pending block. The returned block can be
|
|
|
|
// nil in case the pending block is not initialized.
|
2016-12-13 12:03:18 +00:00
|
|
|
//
|
|
|
|
// Note, to access both the pending block and the pending state
|
|
|
|
// simultaneously, please use Pending(), as the pending state can
|
2016-11-30 09:48:48 +00:00
|
|
|
// change between multiple method calls
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) PendingBlock() *types.Block {
|
|
|
|
return miner.worker.pendingBlock()
|
2016-11-30 09:48:48 +00:00
|
|
|
}
|
|
|
|
|
2021-06-28 14:16:32 +00:00
|
|
|
// PendingBlockAndReceipts returns the currently pending block and corresponding receipts.
|
2023-05-31 07:09:49 +00:00
|
|
|
// The returned values can be nil in case the pending block is not initialized.
|
2021-06-28 14:16:32 +00:00
|
|
|
func (miner *Miner) PendingBlockAndReceipts() (*types.Block, types.Receipts) {
|
|
|
|
return miner.worker.pendingBlockAndReceipts()
|
|
|
|
}
|
|
|
|
|
2019-11-24 19:46:34 +00:00
|
|
|
func (miner *Miner) SetEtherbase(addr common.Address) {
|
|
|
|
miner.worker.setEtherbase(addr)
|
2015-07-07 08:58:47 +00:00
|
|
|
}
|
2019-12-10 11:39:14 +00:00
|
|
|
|
2021-07-06 08:35:39 +00:00
|
|
|
// SetGasCeil sets the gaslimit to strive for when mining blocks post 1559.
|
|
|
|
// For pre-1559 blocks, it sets the ceiling.
|
|
|
|
func (miner *Miner) SetGasCeil(ceil uint64) {
|
|
|
|
miner.worker.setGasCeil(ceil)
|
|
|
|
}
|
|
|
|
|
2019-12-10 11:39:14 +00:00
|
|
|
// SubscribePendingLogs starts delivering logs from pending transactions
|
|
|
|
// to the given channel.
|
2020-05-25 08:20:09 +00:00
|
|
|
func (miner *Miner) SubscribePendingLogs(ch chan<- []*types.Log) event.Subscription {
|
|
|
|
return miner.worker.pendingLogsFeed.Subscribe(ch)
|
2019-12-10 11:39:14 +00:00
|
|
|
}
|
2022-05-18 14:33:37 +00:00
|
|
|
|
2022-11-02 09:32:20 +00:00
|
|
|
// BuildPayload builds the payload according to the provided parameters.
|
|
|
|
func (miner *Miner) BuildPayload(args *BuildPayloadArgs) (*Payload, error) {
|
|
|
|
return miner.worker.buildPayload(args)
|
2022-05-18 14:33:37 +00:00
|
|
|
}
|