cerc-io/plugeth-statediff
11
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Set state node diff field to false for snapshots #18

Merged
roysc merged 3 commits from snapshot-patch into main 2023-09-29 18:06:23 +00:00
Conversation 1 Commits 3 Files Changed 17
+63 -34
roysc commented 2023-09-28 10:06:16 +00:00
Owner
Copy Link
Copy Source

Needed for cerc-io/ipld-eth-state-snapshot#1

Needed for https://git.vdb.to/cerc-io/ipld-eth-state-snapshot/pulls/1
telackey was assigned by roysc 2023-09-28 10:06:16 +00:00
roysc added 1 commit 2023-09-28 10:06:17 +00:00
Set state node diff field to false for snapshots
Test / Run unit tests (pull_request) Successful in 16m11s
Details
Test / Run compliance tests (pull_request) Successful in 3m51s
Details
Test / Run integration tests (pull_request) Has been cancelled
Details
b50e636204
roysc force-pushed snapshot-patch from b50e636204 to f0e7c74362 2023-09-28 11:38:24 +00:00 Compare
roysc requested review from i-norden 2023-09-28 14:36:47 +00:00
roysc requested review from telackey 2023-09-28 19:49:13 +00:00
telackey approved these changes 2023-09-28 22:28:46 +00:00
telackey left a comment
Contributor
Copy Link
Copy Source

Other than adding a comment, LGTM.

Other than adding a comment, LGTM.
indexer/constructor.go Outdated
@@ -38,6 +38,7 @@ func NewStateDiffIndexer(
chainConfig *params.ChainConfig,
nodeInfo node.Info,
config interfaces.Config,
diff bool,
telackey commented 2023-09-28 22:27:22 +00:00
Contributor
Copy Link
Copy Source

Could you add a comment as to the purpose of the flag?

Could you add a comment as to the purpose of the flag?
roysc marked this conversation as resolved
indexer/database/file/indexer.go Outdated
@@ -64,3 +64,3 @@
// NewStateDiffIndexer creates a void implementation of interfaces.StateDiffIndexer
func NewStateDiffIndexer(chainConfig *params.ChainConfig, config Config, nodeInfo node.Info) (*StateDiffIndexer, error) {
func NewStateDiffIndexer(chainConfig *params.ChainConfig, config Config, nodeInfo node.Info, diff bool) (*StateDiffIndexer, error) {
telackey commented 2023-09-28 22:27:47 +00:00
Contributor
Copy Link
Copy Source

Same as above.

Same as above.
roysc marked this conversation as resolved
indexer/database/file/sql_writer.go Outdated
@@ -57,3 +58,3 @@
// NewSQLWriter creates a new pointer to a Writer
func NewSQLWriter(wc io.WriteCloser, watchedAddressesFilePath string) *SQLWriter {
func NewSQLWriter(wc io.WriteCloser, watchedAddressesFilePath string, diff bool) *SQLWriter {
telackey commented 2023-09-28 22:28:00 +00:00
Contributor
Copy Link
Copy Source

Same.

Same.
roysc marked this conversation as resolved
indexer/database/sql/indexer.go Outdated
@@ -53,2 +53,3 @@
// NewStateDiffIndexer creates a sql implementation of interfaces.StateDiffIndexer
func NewStateDiffIndexer(ctx context.Context, chainConfig *params.ChainConfig, db Database) (*StateDiffIndexer, error) {
func NewStateDiffIndexer(
ctx context.Context, chainConfig *params.ChainConfig, db Database, diff bool,
telackey commented 2023-09-28 22:28:08 +00:00
Contributor
Copy Link
Copy Source

Same.

Same.
roysc marked this conversation as resolved
roysc added 1 commit 2023-09-29 12:50:32 +00:00
Godoc for indexer constructor
Test / Run unit tests (pull_request) Successful in 16m38s
Details
Test / Run compliance tests (pull_request) Successful in 3m49s
Details
Test / Run integration tests (pull_request) Successful in 31m21s
Details
d80e2104de
roysc added 1 commit 2023-09-29 13:00:27 +00:00
Godoc for indexer constructor
Test / Run unit tests (pull_request) Successful in 16m52s
Details
Test / Run compliance tests (pull_request) Successful in 3m23s
Details
Test / Run integration tests (pull_request) Successful in 28m54s
Details
0b2be15cf9
roysc merged commit e70c55bf86 into main 2023-09-29 18:06:23 +00:00
roysc deleted branch snapshot-patch 2023-09-29 18:06:24 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
i-norden
telackey
Labels
Clear labels
Copied from Github
An issue or PR manually copied from GitHub.
 Kind/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
AFDudley Alex cerccicd ericlewis i-norden (Ian Norden) rachmaninovquar rjk-laconic roysc (Roy Crihfield) srw zramsay
No Assignees telackey
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cerc-io/plugeth-statediff#18