From 7f1959e124771c7789697950d5187da277f331fe Mon Sep 17 00:00:00 2001 From: Roy Crihfield Date: Wed, 29 May 2024 17:02:28 +0800 Subject: [PATCH] rm TODOs --- go.sum | 4 ++-- indexer/mocks/test_data.go | 2 +- service.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/go.sum b/go.sum index 1a6c5f8..314bbfc 100644 --- a/go.sum +++ b/go.sum @@ -1,6 +1,6 @@ cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= -git.vdb.to/cerc-io/plugeth v1.13.14-cerc-1 h1:ay44209w1SyFlwUCqPNgH4TGn0yv4Vg2JymwJfEgp4Q= -git.vdb.to/cerc-io/plugeth v1.13.14-cerc-1/go.mod h1:sUMNKCsvK1Afdogl+n8QTm9hmCX4fa0X3SqE+xru89k= +git.vdb.to/cerc-io/plugeth v1.13.14-cerc-2 h1:wUnIMCUP+e/F6f/JA1Ui51AagmYkxctEcyg66QJJj0o= +git.vdb.to/cerc-io/plugeth v1.13.14-cerc-2/go.mod h1:sUMNKCsvK1Afdogl+n8QTm9hmCX4fa0X3SqE+xru89k= git.vdb.to/cerc-io/plugeth-utils v1.5.0-cerc-1 h1:WMdo9Pb5lAn0e2WC1CcD6/mRTWwU0r2KjFoEh0mh2rs= git.vdb.to/cerc-io/plugeth-utils v1.5.0-cerc-1/go.mod h1:Wf47tlE95PHZto1PMFRlmQAf98MBoNSRbwnQxeq0+Z0= github.com/AndreasBriese/bbloom v0.0.0-20190306092124-e2d15f34fcf9/go.mod h1:bOvUY6CB00SOBii9/FifXqc0awNKxLFCL/+pkDPuyl8= diff --git a/indexer/mocks/test_data.go b/indexer/mocks/test_data.go index d1a684b..b940207 100644 --- a/indexer/mocks/test_data.go +++ b/indexer/mocks/test_data.go @@ -42,7 +42,7 @@ var ( // block data TestChainConfig = params.MainnetChainConfig BlockNumber = TestChainConfig.LondonBlock - BlockTime = *TestChainConfig.CancunTime // TODO: verify this + BlockTime = *TestChainConfig.CancunTime // canonical block at London height // includes 5 transactions: 3 Legacy + 1 EIP-2930 + 1 EIP-1559 diff --git a/service.go b/service.go index 5c729f2..7d97073 100644 --- a/service.go +++ b/service.go @@ -825,7 +825,7 @@ func (sds *Service) writeStateDiff(block *types.Block, parentRoot common.Hash, p } defer tx.RollbackOnFailure(err) - // TODO: review/remove the need to sync here + // TODO: review necessity of locking here var nodeMtx, ipldMtx sync.Mutex nodeSink := func(node types2.StateLeafNode) error { defer metrics.UpdateDuration(time.Now(), metrics.IndexerMetrics.OutputTimer)