cerc-io/plugeth-statediff
16
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

add missing rollback, doc

Browse Source
This commit is contained in:
Roy Crihfield 2023-09-26 18:06:45 +08:00
parent 77e00278e4
commit 5b51346a83
3 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
indexer/database/sql/batch_tx.go
View File

@ -85,7 +85,6 @@ func (tx *BatchTx) BlockNumber() string {
} }
func (tx *BatchTx) RollbackOnFailure(err error) { func (tx *BatchTx) RollbackOnFailure(err error) {
if p := recover(); p != nil { if p := recover(); p != nil {
defer tx.close() defer tx.close()
log.Info("panic detected before tx submission, rolling back the tx", "panic", p) log.Info("panic detected before tx submission, rolling back the tx", "panic", p)

3
indexer/interfaces/interfaces.go
View File

@ -54,8 +54,11 @@ type StateDiffIndexer interface {
// Batch required for indexing data atomically // Batch required for indexing data atomically
type Batch interface { type Batch interface {
// Submit commits the batch transaction
Submit() error Submit() error
// BlockNumber is the block number of the header this batch contains
BlockNumber() string BlockNumber() string
// RollbackOnFailure rolls back the batch transaction if the error is not nil
RollbackOnFailure(error) RollbackOnFailure(error)
} }

1
service.go
View File

@ -823,6 +823,7 @@ func (sds *Service) writeStateDiff(block *types.Block, parentRoot common.Hash, p
if err != nil { if err != nil {
return err return err
} }
defer tx.RollbackOnFailure(err)
// TODO: review/remove the need to sync here // TODO: review/remove the need to sync here
var nodeMtx, ipldMtx sync.Mutex var nodeMtx, ipldMtx sync.Mutex