We were ignoring quite a few error cases, and had one case where we weren't actually updating state where we wanted to. Unfortunately, if the linter doesn't pass, nobody has any reason to actually check lint failures in CI. There are three remaining XXXs marked in the code for lint.
		
			
				
	
	
		
			47 lines
		
	
	
		
			769 B
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			47 lines
		
	
	
		
			769 B
		
	
	
	
		
			Go
		
	
	
	
	
	
| package cli
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"os"
 | |
| 
 | |
| 	"github.com/urfave/cli/v2"
 | |
| 	"golang.org/x/xerrors"
 | |
| )
 | |
| 
 | |
| type PrintHelpErr struct {
 | |
| 	Err error
 | |
| 	Ctx *cli.Context
 | |
| }
 | |
| 
 | |
| func (e *PrintHelpErr) Error() string {
 | |
| 	return e.Err.Error()
 | |
| }
 | |
| 
 | |
| func (e *PrintHelpErr) Unwrap() error {
 | |
| 	return e.Err
 | |
| }
 | |
| 
 | |
| func (e *PrintHelpErr) Is(o error) bool {
 | |
| 	_, ok := o.(*PrintHelpErr)
 | |
| 	return ok
 | |
| }
 | |
| 
 | |
| func ShowHelp(cctx *cli.Context, err error) error {
 | |
| 	return &PrintHelpErr{Err: err, Ctx: cctx}
 | |
| }
 | |
| 
 | |
| func RunApp(app *cli.App) {
 | |
| 	if err := app.Run(os.Args); err != nil {
 | |
| 		if os.Getenv("LOTUS_DEV") != "" {
 | |
| 			log.Warnf("%+v", err)
 | |
| 		} else {
 | |
| 			fmt.Printf("ERROR: %s\n\n", err)
 | |
| 		}
 | |
| 		var phe *PrintHelpErr
 | |
| 		if xerrors.As(err, &phe) {
 | |
| 			_ = cli.ShowCommandHelp(phe.Ctx, phe.Ctx.Command.Name)
 | |
| 		}
 | |
| 		os.Exit(1)
 | |
| 	}
 | |
| }
 |