9dc29bf3f7
* feat: api: improve the correctness of Eth's trace_block (#11609) * Improve the correctness of Eth's trace_block - Improve encoding/decoding of parameters and return values: - Encode "native" parameters and return values with Solidity ABI. - Correctly decode parameters to "create" calls. - Use the correct (ish) output for "create" calls. - Handle all forms of "create". - Make robust with respect to reverts: - Use the actor ID/address from the trace instead of looking it up in the state-tree (may not exist in the state-tree due to a revert). - Gracefully handle failed actor/contract creation. - Improve performance: - We avoid looking anything up in the state-tree when translating the trace, which should significantly improve performance. - Improve code readability: - Remove all "backtracking" logic. - Use an "environment" struct to store temporary state instead of attaching it to the trace. - Fix random bugs: - Fix an allocation bug in the "address" logic (need to set the capacity before modifying the slice). - Improved error checking/handling. - Use correct types for `trace_block` action/results (create, call, etc.). - And use the correct types for Result/Action structs instead of reusing the same "Call" action every time. - Improve error messages. * Make gen Make gen --------- Co-authored-by: Steven Allen <steven@stebalien.com> |
||
|---|---|---|
| .. | ||
| account | ||
| cron | ||
| datacap | ||
| evm | ||
| init | ||
| market | ||
| miner | ||
| multisig | ||
| paych | ||
| power | ||
| reward | ||
| system | ||
| verifreg | ||
| builtin.go | ||
| builtin.go.template | ||
| README.md | ||
| registry.go | ||
| registry.go.template | ||
Actors
This package contains shims for abstracting over different actor versions.
Design
Shims in this package follow a few common design principles.
Structure Agnostic
Shims interfaces defined in this package should (ideally) not change even if the structure of the underlying data changes. For example:
- All shims store an internal "store" object. That way, state can be moved into a separate object without needing to add a store to the function signature.
- All functions must return an error, even if unused for now.
Minimal
These interfaces should be expanded only as necessary to reduce maintenance burden.
Queries, not field assessors.
When possible, functions should query the state instead of simply acting as field assessors. These queries are more likely to remain stable across specs-actor upgrades than specific state fields.
Note: there is a trade-off here. Avoid implementing complicated query logic inside these shims, as it will need to be replicated in every shim.