Commit Graph

20 Commits

Author SHA1 Message Date
Rod Vagg
6a8110322d chore: lint: update golangci lint config
* remove and replace some linters
* remove some exclusions
* make all exclusions more explicit matches
2024-05-13 14:52:09 +10:00
Mikers
5e5a81bf23
add go linter - "unused" (#11235)
* add go linter - "unused"

* use _ to name unused but needed padding variable

* remove unused code

* add queue test to appease unused linter

* remove unused code in test

* remove unused func

* remove unused struct identified by linter

* remove unused variable

* remove unused code

* remove unused file

* remove unused struct

* remove unused function

* remove unused observe peers function in raft

* remove unused declareFaults function

* annotate nolint:unused on needed methods
2023-09-05 12:19:43 -10:00
Mikers
70b1bca173 remove deprecated structchecklinter, TOOD add support for linter named "unused" 2023-08-08 13:29:29 -10:00
Geoff Stuart
9e94dc5550
Delete lotus-pond (#9352) 2022-09-21 15:39:46 -04:00
vyzo
1c8880ed2c dear linter, using xerrors is what we want to do. 2022-04-21 20:10:34 +03:00
Steven Allen
e0d2b9526e ci: fix linting 2022-04-20 12:06:28 +02:00
Steven Allen
f5029a0187 lint: don't skip builtin 2021-03-25 17:21:56 -07:00
Steven Allen
5733c71c50 Lint everything
We were ignoring quite a few error cases, and had one case where we weren't
actually updating state where we wanted to. Unfortunately, if the linter doesn't
pass, nobody has any reason to actually check lint failures in CI.

There are three remaining XXXs marked in the code for lint.
2020-08-20 20:46:36 -07:00
Jakub Sztandera
5605aae269
Fix even more lint warnings
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
2020-06-02 16:29:39 +02:00
Jakub Sztandera
d6615b6286
Cleanup many lint warnings
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
2020-05-27 22:53:20 +02:00
Jakub Sztandera
b2a0ad68dd
Add gofmt to golangci-lint
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>
2020-02-18 13:19:04 +01:00
Jakub Sztandera
8e1a1a86a4 Remove doc lint
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-11 10:00:24 +02:00
Jakub Sztandera
8cd484a8b0 Change lint options
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-10 15:42:18 +02:00
Jakub Sztandera
c69e241f33 Change regex
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-08 17:42:49 +02:00
Jakub Sztandera
eae1851aaf Run docstring lint in seprate job
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-08 17:36:24 +02:00
Jakub Sztandera
4df601ea6a Fix imports and range reference warnings
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-08 17:14:36 +02:00
Jakub Sztandera
71dfa38032 Update linter
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-05 13:21:54 +02:00
Jakub Sztandera
808a1e9deb Add skeleton of a config
Took way longer than it should had because I was researching exisiting
options.

As it turns out, nothing nice exists that would handle:
 - Multiple overridiable config files
 - Defaults provided in a struct
 - Output in a struct

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-04 11:25:28 +02:00
Jakub Sztandera
4d15bbdc6f Change linters
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-02 15:28:17 +02:00
Jakub Sztandera
126fa8913a Add golint config
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
2019-07-01 23:11:34 +02:00