vyzo
31d193702b
don't parse error messages, just check exit codes
2022-04-27 17:57:04 +03:00
Łukasz Magiera
d7c52f8adf
sealing: ComputeDataCid miner API
2022-04-26 21:37:48 +02:00
Cory Schwartz
9fd3f3f73a
fix itests
2022-04-20 20:51:15 -07:00
vyzo
5ceaeafa6e
fix TODO for proof type, now that we have the testing bundle
2022-04-20 12:47:06 +03:00
Geoff Stuart
49d6c07280
Implemented StateLoockupRobustAddress
2022-04-14 17:41:18 -04:00
vyzo
c5e3ca3855
fix more rebase issues
2022-04-14 19:52:58 +03:00
vyzo
dec2b312af
fix lint
2022-04-14 19:33:24 +03:00
vyzo
73e7c42b7e
mark TODO for fixing policy stuffs in test
2022-04-14 19:31:34 +03:00
vyzo
2c9ea8c46b
fix test
2022-04-14 19:31:34 +03:00
vyzo
71913521f9
fix itest migrations
2022-04-14 19:30:47 +03:00
Aayush
3370847f3e
Implement FIP-0031
2022-04-14 19:28:16 +03:00
jennijuju
137f494619
tidy and gen
2022-04-12 13:53:03 +02:00
jennijuju
0dcad9cc18
Merge branch 'releases' into jen/mergeback
2022-04-12 01:25:02 +02:00
dirkmc
c34ade9ffb
Update itests/kit/rpc.go
...
Co-authored-by: Anton Evangelatov <anton.evangelatov@gmail.com>
2022-04-07 13:32:00 +02:00
Dirk McCormick
5f0489ace0
fix: testkit: give up on waiting for the RPC server to shutdown after 1 second
2022-04-07 12:22:36 +02:00
Łukasz Magiera
ebd34f1884
feat: storage: Parallel proving checks
2022-03-29 11:45:08 -04:00
Łukasz Magiera
54cb55a7ae
feat: miner: API/CLI to compute window-post
2022-03-28 17:06:51 -04:00
Łukasz Magiera
82343a06e7
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-03-25 16:49:46 -04:00
Łukasz Magiera
3f152ae2bf
workers: cmd/lotus-seal-worker->cmd/lotus-worker
2022-03-24 18:37:01 -04:00
Łukasz Magiera
92e4caa151
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-03-21 12:09:47 +01:00
Łukasz Magiera
e767981aaf
itests: Fix ccupgrade post test
2022-03-21 12:07:00 +01:00
Łukasz Magiera
0536eb898d
itests: Share WaitForSectorActive correctly
2022-03-21 12:07:00 +01:00
Łukasz Magiera
433e9c351d
config: Fix doc on PreferNewSectorsForDeals; gofmt
2022-03-21 12:07:00 +01:00
Łukasz Magiera
49a6d7ebcc
itests: Breakup ccupgrade_test.go
2022-03-21 12:07:00 +01:00
Łukasz Magiera
4c25358a08
itests: Test Sealing.MakeCCSectorsAvailable
2022-03-21 12:07:00 +01:00
Łukasz Magiera
ecd1ab4b42
itests: Test Sealing.PreferNewSectorsForDeals
2022-03-21 12:07:00 +01:00
Łukasz Magiera
36f1dd7bb3
itests: Fix flaky TestWindowPostWorkerSkipBadSector
2022-03-18 20:51:47 +01:00
Łukasz Magiera
7b81369c8c
wdpost: Don't attempt to snark with skipped sectors
2022-03-18 19:45:25 +01:00
Łukasz Magiera
32818c528f
wdpost: Test repro broken challenge skipping
2022-03-18 12:32:16 +01:00
Anton Evangelatov
0d6493ec3f
resolve merge conflicts with master
2022-03-18 12:28:22 +01:00
Łukasz Magiera
aa124cf414
fix lint issues
2022-03-18 11:38:27 +01:00
Łukasz Magiera
6ddbe41376
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-03-18 10:54:44 +01:00
Łukasz Magiera
42b2adddee
fix: itests: Don't hang on exit in MineBlocksMustPost
2022-03-18 10:42:21 +01:00
Łukasz Magiera
5e14892ef8
sealing: fix lint issues
2022-03-16 22:30:57 +01:00
Łukasz Magiera
62a393bf12
sealing: Address snap queue review
2022-03-16 22:30:09 +01:00
Łukasz Magiera
1158a928ec
itests: Test reverting Available sectors to Proving
2022-03-16 22:29:40 +01:00
Łukasz Magiera
a9d757f3a0
itests: TestTooManyMarkedForUpgrade is not applicable anymore
2022-03-16 22:29:40 +01:00
Łukasz Magiera
2cef55a4f6
feat: sealing: Sector upgrade queue
2022-03-16 22:29:37 +01:00
Łukasz Magiera
a3bdd29615
Merge pull request #8330 from filecoin-project/feat/snap-queue
...
feat: sealing: Sector upgrade queue
2022-03-16 22:24:45 +01:00
Łukasz Magiera
3b2a1ea41d
sealing: fix lint issues
2022-03-16 20:28:15 +01:00
Łukasz Magiera
724d80cf02
sealing: Address snap queue review
2022-03-16 20:04:48 +01:00
Łukasz Magiera
799d3ebe5e
itests: Test reverting Available sectors to Proving
2022-03-16 19:05:53 +01:00
Darko Brdareski
79453663b3
feat: Add additional test annotations ( #8272 )
...
* Annotate api,proxy_util,blockstore_badger, policy tests
* Annotate splitstore: bsbadger / markset
* Annotate splitstore feature
* Annotate union/timed blockstore tests
* Annotate openrpc, diff_adt tests
* Annotate error,drand,events tests
* Annotate predicates_test
* Fix annotations
* Annotate tscache, gen tests
* Annotate fundmanager test
* Annotate repub and selection tests
* Annotate statetree_test
* Annotate forks_test
* Annotate searchwait_test.go
* Fix duplicated @@ symbols
* Annotate chain stmgr/store tests
* Annotate more (types) tests
* More tests annotated
* Annotate conformance chaos actor tests
* Annotate more integration tests
* Annotate journal system tests
* Annotate more tests.
* Annotate gas,head buffer behaviors
* Fix markset annotations
* doc: test annotations for the markets dagstore wrapper
* Annotate miner_api test in dagstore
* Annotate more test files
* Remove bad annotations from fsrepo
* Annotate wdpost system
* Remove bad annotations
* Renamce "conformance" to "chaos_actor" tests
* doc: stm annotations for blockheader & election proof tests
* Annotate remaining "A" tests
* annotate: stm for error_test
* memrepo_test.go
* Annotate "b" file tests
* message_test.go
* doc: stm annotate for fsrepo_test
* Annotate "c" file tests
* Annotate "D" test files
* message_test.go
* doc: stm annotate for chain, node/config & client
* docs: stm annotate node_test
* Annotate u,v,wl tests
* doc: stm annotations for various test files
* Annotate "T" test files
* doc: stm annotate for proxy_util_test & policy_test
* doc: stm annotate for various tests
* doc: final few stm annotations
* Add mempool unit tests
* Add two more memPool Add tests
* Update submodules
* Add check function tests
* Add stm annotations, refactor test helper
* Annotate api,proxy_util,blockstore_badger, policy tests
* Annotate splitstore: bsbadger / markset
solving merge conflicts
* Annotate splitstore feature
* Annotate union/timed blockstore tests
* Annotate openrpc, diff_adt tests
* Annotate error,drand,events tests
* Annotate predicates_test
* Fix annotations
* Annotate tscache, gen tests
* Annotate fundmanager test
* Annotate statetree_test
* Annotate forks_test
* Annotate searchwait_test.go
* Fix duplicated @@ symbols
* Annotate chain stmgr/store tests
* Annotate more (types) tests
* More tests annotated
* Annotate conformance chaos actor tests
* Annotate more integration tests
* Annotate journal system tests
* Annotate more tests.
* Annotate gas,head buffer behaviors
solve merge conflict
* Fix markset annotations
* Annotate miner_api test in dagstore
* Annotate more test files
* doc: test annotations for the markets dagstore wrapper
* Annotate wdpost system
* Renamce "conformance" to "chaos_actor" tests
* Annotate remaining "A" tests
* doc: stm annotations for blockheader & election proof tests
* annotate: stm for error_test
* Annotate "b" file tests
* memrepo_test.go
* Annotate "c" file tests
* message_test.go
* Annotate "D" test files
* doc: stm annotate for fsrepo_test
* Annotate u,v,wl tests
* message_test.go
* doc: stm annotate for chain, node/config & client
* docs: stm annotate node_test
* Annotate "T" test files
* doc: stm annotations for various test files
* Add mempool unit tests
solve merge conflict
* doc: stm annotate for proxy_util_test & policy_test
* doc: stm annotate for various tests
* doc: final few stm annotations
* Add two more memPool Add tests
* Update submodules
* Add check function tests
solve conflict
* Add stm annotations, refactor test helper
solve merge conflict
* Change CLI test kinds to "unit"
* Fix double merged test
* Fix ccupgrade_test merge
* Fix lint issues
* Add stm annotation to types_Test
* Test vectors submodule
* Add file annotation to burn_test
Co-authored-by: Nikola Divic <divicnikola@gmail.com>
Co-authored-by: TheMenko <themenkoprojects@gmail.com>
2022-03-16 18:37:34 +01:00
Łukasz Magiera
8600ae2ac4
itests: TestTooManyMarkedForUpgrade is not applicable anymore
2022-03-16 17:48:02 +01:00
Łukasz Magiera
aef2ec513f
feat: sealing: Sector upgrade queue
2022-03-16 17:33:05 +01:00
Łukasz Magiera
135aef78d7
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-03-11 17:04:58 +01:00
Łukasz Magiera
ad66ad4f7d
fix: sealing fsm: Handle inputLk correctly
2022-03-11 13:34:14 +01:00
Łukasz Magiera
231893a794
feat: shed: ItestD
2022-03-10 19:39:10 +01:00
Łukasz Magiera
046a9f8af0
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-03-09 16:27:03 +01:00
Anton Evangelatov
b9fe61f9da
Merge branch 'master' into nonsense/refactor-nodetype
2022-03-07 11:51:28 +01:00
Anton Evangelatov
acbfc879aa
config: extract DealmakingConfig and Sealing config from Lotus for Boost ( #8172 )
...
* refactor sealingCfg and dealmakingCfg to be able to abstract Config
* fix error messages
2022-03-03 15:37:23 +01:00
Anton Evangelatov
f1f878a000
unexport repo types; use a global var for every repo type
2022-03-03 15:37:23 +01:00
Anton Evangelatov
e3edab66e3
refactor RepoType
2022-03-03 15:37:23 +01:00
Masih H. Derkani
aacc246ba3
Merge branch 'master' into feat/cid-to-piece-idx
2022-03-02 14:06:30 +00:00
Masih H. Derkani
769b0f30ef
Address review comments
...
- Add comment to clarify the reason for loop in testkit
- Trim common prefix in state printed in CLI commands for better
readability
- Upgrade to a tagged release of `go-fil-markets` that includes indexing
work; see: https://github.com/filecoin-project/go-fil-markets/pull/673
- Fix typo in CLI usage.
- Add comments to note that it is safe to use fx `OnStart` context when
starting the provider engine.
- Fix string concatenation in error message formatting.
2022-03-02 11:04:50 +00:00
zenground0
77a954c7c3
Merge branch 'master' into feat/cid-to-piece-idx
2022-02-28 12:57:11 -07:00
Łukasz Magiera
a0cb6094c6
Merge remote-tracking branch 'origin/master' into feat/paych-avail-reuse
2022-02-22 10:55:03 +01:00
Elijah Seed-Arita
e2a93a3feb
add itests ensemble mocknet getter
2022-02-18 11:09:56 -10:00
Łukasz Magiera
681b90768a
Merge remote-tracking branch 'origin/master' into feat/paych-avail-reuse
2022-02-16 10:06:36 +01:00
Łukasz Magiera
36a1934845
paychmgr: Fix tests after api changes
2022-02-14 20:16:30 +01:00
zenground0
977351f419
Fix from Magik to remove hanging behavior
2022-02-14 14:00:41 -05:00
Łukasz Magiera
10af768c60
Merge commit 'origin/release/v1.15.0~2' into feat/paych-avail-reuse
2022-02-14 19:27:12 +01:00
zenground0
2c06eb76d6
Improve MineBlocksMustPost use it in PaychAPI itest
2022-02-14 09:47:18 -05:00
Nikola Divic
34387326d1
test: fix flaky message pool integration tests
...
Using the same pattern described in my previous commit.
I also added the CircuitBreaker to the itests kit as it may be useful
for other integration tests when debugging flakyness caused by timeouts.
2022-02-12 19:52:51 +01:00
Nikola Divic
aca2a0fd1b
test: fix flake in TestMemPoolBatchPushUntrusted integration test
...
The flake was caused by improper waiting for certain chain operations
to finish:
- We didn't wait for messages to be registered as pushed
- We improperly waited for a fixed time (10 seconds) for messages to be
mined, which in the best case would wait longer than necessary and in the
worst case would cause the test to break.
What I did:
- fixed by waiting in a loop for "just enough time". This fixed the flake
and made the test run faster, on average, because we don't have unnecessary
waiting.
- I added a "circuit-breaker" where the wait loop will timeout after 10 seconds.
2022-02-12 17:48:45 +01:00
Nikola Divic
0e8a709f92
Merge branch 'master' of https://github.com/filecoin-project/lotus into bloxico/mempool_tests
2022-02-12 17:11:24 +01:00
Jennifer Wang
de1f4792cd
Merge remote-tracking branch 'origin/master' into jen/v15
2022-02-09 19:27:34 -05:00
Jennifer Wang
6ed97f0d04
Merge branch 'release/v1.14.0' into jen/v15
2022-02-09 03:17:38 -05:00
Łukasz Magiera
4ad97f6a36
make gen
2022-02-08 17:22:41 +01:00
Łukasz Magiera
09cfad9d71
Add FinalizeReplicaUpdate into some more places
2022-02-08 17:22:41 +01:00
Łukasz Magiera
7fa84518c8
itests: Print API info env vars in ThroughRPC tests
2022-02-08 17:22:41 +01:00
Łukasz Magiera
e271bae5ec
try ClearCache for update cache
2022-02-08 17:22:41 +01:00
Aarsh Shah
399a1afd94
Merge remote-tracking branch 'origin/master' into feat/cid-to-piece-idx
2022-02-08 12:37:57 +04:00
Anton Evangelatov
595ad44ee7
refactor indexprovider libp2p host connection to fullnode with meshcreator
2022-02-03 15:44:18 +01:00
Anton Evangelatov
20fc5ffa38
fixing tests
2022-02-03 14:43:20 +01:00
Darko Brdareski
008fbbd652
Add unit and integration tests for mempool
2022-02-02 17:08:50 +01:00
Łukasz Magiera
98f4d37f1a
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-01-31 19:50:52 +00:00
Darko Brdareski
6b8f526df3
Fix merge
2022-01-27 11:06:04 +01:00
Darko Brdareski
e51ce5c508
Merge remote-tracking branch 'upstream/master' into bloxico/system-test-matrix
2022-01-27 10:57:56 +01:00
Łukasz Magiera
55c9271695
post workers: Test skips
2022-01-21 13:33:47 +01:00
Łukasz Magiera
8b19b84140
paych: option to force off-chain get
2022-01-20 18:19:26 +01:00
Łukasz Magiera
533349cc0d
paych: Fix cli tests
2022-01-20 18:17:18 +01:00
Łukasz Magiera
2e76375e8a
Fix paych itests
2022-01-20 18:16:00 +01:00
Łukasz Magiera
33dfcf2663
stores: Fix single post proof reading with updated sectors
2022-01-20 15:27:42 +01:00
Aarsh Shah
9ee940098d
Merge remote-tracking branch 'origin/master' into feat/cid-to-piece-idx
2022-01-20 16:21:48 +04:00
Łukasz Magiera
e476cf7968
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-01-20 13:15:48 +01:00
Łukasz Magiera
b115e2879a
don't defer in a loop
2022-01-20 11:19:57 +01:00
vyzo
c3fb68545a
fix mocknet.New invocation
2022-01-20 11:36:11 +02:00
Łukasz Magiera
fa09b9afb1
post workers: Share resource accounting code
2022-01-18 16:02:37 +01:00
Łukasz Magiera
c79f2b9d38
post workers: Fix lint
2022-01-18 12:11:59 +01:00
Łukasz Magiera
b38141601c
Untangle ffi from api
2022-01-18 11:57:04 +01:00
Łukasz Magiera
03fa955e9e
Cleanup imports
2022-01-18 11:37:24 +01:00
Łukasz Magiera
0c062f9c08
Merge remote-tracking branch 'origin/master' into feat/post-worker
2022-01-18 10:49:42 +01:00
zenground0
a9a523d8c0
Fix TooManyMarkedForUpgrade
2022-01-14 17:14:32 -05:00
zenground0
c6277922ac
Deflake more practically
2022-01-14 17:14:32 -05:00
zenground0
a82ac00d9a
Deflake snap deals integration test
2022-01-14 17:14:32 -05:00
zenground0
d6aa17e21f
Snap Deals Integration
...
- FSM handles the actual cc upgrade process including error states
- PoSting (winning and window) works over upgraded and upgrading sectors
- Integration test and changes to itest framework to reduce flakes
- Update CLI to handle new upgrade
- Update dependencies
2022-01-14 17:14:32 -05:00
Jennifer Wang
e24b454a1f
Bump the master version to v1.13.3-dev
2022-01-14 17:14:32 -05:00
c r
7efaa708a6
reorder transfer
checks so as to ensure sending more money than you have to yourself fails with an error (fixing issue 7596)
...
PR #7637 , also adds tests to make sure behavior is correct across versions.
2022-01-14 17:14:32 -05:00
Aayush Rajasekaran
3a7c364562
Address review
2022-01-14 17:14:32 -05:00
Aayush Rajasekaran
393d8541e2
Update deps
2022-01-14 17:14:32 -05:00
Aayush Rajasekaran
1ef780d96f
Plug in the FFI call
2022-01-14 17:14:32 -05:00
Aayush Rajasekaran
a8cb027c08
Integrate v7 actors
2022-01-14 17:14:32 -05:00
Łukasz Magiera
4a874eff70
post workers: Cleanup, tests
2022-01-14 14:17:52 +01:00
Aarsh Shah
b9d3585f4c
get tests working
2022-01-12 16:55:45 +04:00
Aarsh Shah
3a52f05692
green ci
2022-01-12 15:53:15 +04:00
Aarsh Shah
edfc2c215c
Merge remote-tracking branch 'origin/main' into feat/cid-to-piece-idx
2022-01-12 12:48:54 +04:00
zenground0
c309686679
Fix TooManyMarkedForUpgrade
2022-01-10 15:39:38 +05:30
zenground0
3dc3f55ecb
Deflake more practically
2022-01-10 15:39:38 +05:30
zenground0
f59bfd65da
Deflake snap deals integration test
2022-01-10 15:39:38 +05:30
zenground0
33f2d24f54
Snap Deals Integration
...
- FSM handles the actual cc upgrade process including error states
- PoSting (winning and window) works over upgraded and upgrading sectors
- Integration test and changes to itest framework to reduce flakes
- Update CLI to handle new upgrade
- Update dependencies
2022-01-10 15:39:38 +05:30
Darko Brdareski
dda1a42a2a
Merge branch 'bloxico/system-test-matrix' of https://github.com/filecoin-project/lotus into merge_lotus
2021-12-20 15:48:16 +01:00
Dirk McCormick
bb56e97177
fix: rename query-retrieval-ask to retrieval-ask
2021-12-17 18:01:12 +01:00
Dirk McCormick
b1734f84b3
feat: retrieval ask CLI command
2021-12-17 15:55:12 +01:00
Łukasz Magiera
a4728d3c72
Merge pull request #7578 from filecoin-project/rvagg/SimultaneousTransfersForStoragePerClient
...
feat(graphsync): allow setting of per-peer incoming requests for miners
2021-12-17 14:27:15 +01:00
Łukasz Magiera
bc384c01e3
Merge remote-tracking branch 'origin/master' into deps/update-ctx-dsbs
2021-12-17 13:01:22 +01:00
Rod Vagg
9e7d9affbe
feat(graphsync): allow setting of per-peer incoming requests for miners
2021-12-17 15:04:16 +11:00
Darko Brdareski
3e32aa896c
Annotate client storage deals feature
2021-12-16 14:36:02 +01:00
Darko Brdareski
2f1f35cc71
Annotate storage miner features
2021-12-15 15:30:42 +01:00
vyzo
fc7d4a13b0
fix itests
2021-12-14 16:06:59 +02:00
Darko Brdareski
a64f2421d2
Annotate 'incoming' subsystem
2021-12-14 11:33:33 +01:00
Aayush Rajasekaran
80d5e52923
Merge branch 'master' into next
2021-12-13 13:24:28 -05:00
Darko Brdareski
0addca1070
Fix bad annotations
2021-12-13 13:41:04 +01:00
Darko Brdareski
0169d0dafd
Annotate state feature tests
2021-12-10 16:08:25 +01:00
Darko Brdareski
95f86f9de0
Annotate feature syncer
2021-12-10 11:33:29 +01:00
zenground0
a5be80828a
RemoveData and Decode
...
- Unsealing replica update with sector key works and tested
- Sector key generation added and tested
2021-12-03 15:21:06 -05:00
c r
e16e9ad343
reorder transfer
checks so as to ensure sending more money than you have to yourself fails with an error (fixing issue 7596)
...
PR #7637 , also adds tests to make sure behavior is correct across versions.
2021-11-29 17:26:47 -05:00
Łukasz Magiera
5b5e6b9e44
retrieval: DagSpec.MatchPath -> ExportMerkleProof
2021-11-29 21:14:00 +01:00
Łukasz Magiera
227188e908
retrieval: Test non-matching path traversal
2021-11-29 20:52:55 +01:00
Łukasz Magiera
61791b90ea
retrieval: Only output matching nodes, MatchPath dagspec
2021-11-29 20:40:55 +01:00
Peter Rabbitson
407bf4961c
Modify preexisting test to reflect the simple-path car export behavior
...
I am open to having a flag or something, as long as the behavior reflected in
deals_partial_retrieval_dm-level_test.go can be preserved for v0, and opt-in for v1
2021-11-24 15:31:19 +01:00
Peter Rabbitson
46937a1b9f
Add tests cementing the DM-level behavior on simple paths
2021-11-24 15:31:15 +01:00
Łukasz Magiera
597b72e286
retrieval: Fix lint, cli docsgen
2021-11-22 12:46:29 +01:00
Łukasz Magiera
b83a9b902a
gofmt
2021-11-22 12:46:17 +01:00
Łukasz Magiera
b26906963b
retrieval: Support multi-root export
2021-11-22 12:46:17 +01:00
Łukasz Magiera
d0503d409f
fix TestPartialRetrieval
2021-11-22 12:46:04 +01:00
Łukasz Magiera
b868769ec8
more retrieval api work
2021-11-22 12:46:02 +01:00
Łukasz Magiera
89138bab4d
Simplify retrieval APIs
2021-11-22 12:45:42 +01:00
Aayush Rajasekaran
5f1783c9a5
Address review
2021-11-19 15:11:13 -05:00
Aarsh Shah
7655e660f3
integrate store-the-hash
2021-11-18 12:07:12 +04:00
Aayush Rajasekaran
8665e32221
Update deps
2021-11-17 15:55:14 -05:00
Aayush Rajasekaran
07f1be0ff6
Plug in the FFI call
2021-11-17 15:55:14 -05:00
Aayush Rajasekaran
1449644c34
Integrate v7 actors
2021-11-17 15:55:14 -05:00
Aarsh Shah
60fe55cdc0
fix lint and gen
2021-11-17 15:25:25 +04:00
Aarsh Shah
caf3cfa7d8
Merge branch 'feat/cid-to-piece-idx' into feat/indexer-provider
2021-11-17 11:43:49 +04:00
Aarsh Shah
bfee6699d2
update go mod and inject store the hash index in dagstore
2021-11-17 11:42:14 +04:00
Dirk McCormick
627d4fbf74
wip: storage miner index provider
2021-11-16 17:45:42 +01:00
Aarsh Shah
189f5f8aae
fix deals test
2021-11-12 09:43:42 +01:00
Dirk McCormick
e309293a47
fix: lint fixes
2021-11-12 09:43:42 +01:00
Aarsh Shah
4d87f16e95
better comparision in test
2021-11-12 09:43:42 +01:00