Merge pull request #8099 from filecoin-project/feat/rcmgr-metrics-redux

don't track peer ids in rcmgr metrics
This commit is contained in:
Łukasz Magiera 2022-02-15 15:52:26 +01:00 committed by GitHub
commit fd66c0dcf6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -118,7 +118,6 @@ func (r rcmgrMetrics) AllowStream(p peer.ID, dir network.Direction) {
} else { } else {
ctx, _ = tag.New(ctx, tag.Upsert(metrics.Direction, "outbound")) ctx, _ = tag.New(ctx, tag.Upsert(metrics.Direction, "outbound"))
} }
ctx, _ = tag.New(ctx, tag.Upsert(metrics.PeerID, p.Pretty()))
stats.Record(ctx, metrics.RcmgrAllowStream.M(1)) stats.Record(ctx, metrics.RcmgrAllowStream.M(1))
} }
@ -129,19 +128,16 @@ func (r rcmgrMetrics) BlockStream(p peer.ID, dir network.Direction) {
} else { } else {
ctx, _ = tag.New(ctx, tag.Upsert(metrics.Direction, "outbound")) ctx, _ = tag.New(ctx, tag.Upsert(metrics.Direction, "outbound"))
} }
ctx, _ = tag.New(ctx, tag.Upsert(metrics.PeerID, p.Pretty()))
stats.Record(ctx, metrics.RcmgrBlockStream.M(1)) stats.Record(ctx, metrics.RcmgrBlockStream.M(1))
} }
func (r rcmgrMetrics) AllowPeer(p peer.ID) { func (r rcmgrMetrics) AllowPeer(p peer.ID) {
ctx := context.Background() ctx := context.Background()
ctx, _ = tag.New(ctx, tag.Upsert(metrics.PeerID, p.Pretty()))
stats.Record(ctx, metrics.RcmgrAllowPeer.M(1)) stats.Record(ctx, metrics.RcmgrAllowPeer.M(1))
} }
func (r rcmgrMetrics) BlockPeer(p peer.ID) { func (r rcmgrMetrics) BlockPeer(p peer.ID) {
ctx := context.Background() ctx := context.Background()
ctx, _ = tag.New(ctx, tag.Upsert(metrics.PeerID, p.Pretty()))
stats.Record(ctx, metrics.RcmgrBlockPeer.M(1)) stats.Record(ctx, metrics.RcmgrBlockPeer.M(1))
} }
@ -160,7 +156,6 @@ func (r rcmgrMetrics) BlockProtocol(proto protocol.ID) {
func (r rcmgrMetrics) BlockProtocolPeer(proto protocol.ID, p peer.ID) { func (r rcmgrMetrics) BlockProtocolPeer(proto protocol.ID, p peer.ID) {
ctx := context.Background() ctx := context.Background()
ctx, _ = tag.New(ctx, tag.Upsert(metrics.ProtocolID, string(proto))) ctx, _ = tag.New(ctx, tag.Upsert(metrics.ProtocolID, string(proto)))
ctx, _ = tag.New(ctx, tag.Upsert(metrics.PeerID, p.Pretty()))
stats.Record(ctx, metrics.RcmgrBlockProtoPeer.M(1)) stats.Record(ctx, metrics.RcmgrBlockProtoPeer.M(1))
} }
@ -179,7 +174,6 @@ func (r rcmgrMetrics) BlockService(svc string) {
func (r rcmgrMetrics) BlockServicePeer(svc string, p peer.ID) { func (r rcmgrMetrics) BlockServicePeer(svc string, p peer.ID) {
ctx := context.Background() ctx := context.Background()
ctx, _ = tag.New(ctx, tag.Upsert(metrics.ServiceID, svc)) ctx, _ = tag.New(ctx, tag.Upsert(metrics.ServiceID, svc))
ctx, _ = tag.New(ctx, tag.Upsert(metrics.PeerID, p.Pretty()))
stats.Record(ctx, metrics.RcmgrBlockSvcPeer.M(1)) stats.Record(ctx, metrics.RcmgrBlockSvcPeer.M(1))
} }