feat: bundle: only write git tags for newly packed bundles

This commit is contained in:
Aayush 2023-02-17 14:17:30 -05:00
parent 4dedced175
commit f41435d285

View File

@ -1,8 +1,8 @@
package main package main
import ( import (
"fmt"
"os" "os"
"strconv"
"strings" "strings"
"text/template" "text/template"
@ -40,38 +40,42 @@ func splitOverride(override string) (string, string) {
} }
func main() { func main() {
// read metadata from the embedded bundle, includes all info except git tags
metadata, err := build.ReadEmbeddedBuiltinActorsMetadata() metadata, err := build.ReadEmbeddedBuiltinActorsMetadata()
if err != nil { if err != nil {
panic(err) panic(err)
} }
var metadataSpecificVersion []*build.BuiltinActorsMetadata // IF args have been provided, extract git tag info from them, otherwise
// see ./build/actors/pack.sh // rely on previously embedded metadata for git tags.
// expected args are:
// $(GOCC) run ./gen/bundle $(VERSION) $(RELEASE) $(RELEASE_OVERRIDES)
// overrides are in the format network_name=override
if len(os.Args) > 1 { if len(os.Args) > 1 {
version := os.Args[1] // see ./build/actors/pack.sh
// (optional) expected args are:
// $(GOCC) run ./gen/bundle $(VERSION) $(RELEASE) $(RELEASE_OVERRIDES)
// overrides are in the format network_name=override
gitTag := os.Args[2]
packedActorsVersion, err := strconv.Atoi(os.Args[1][1:])
if err != nil {
panic(err)
}
overrides := map[string]string{} overrides := map[string]string{}
for _, override := range os.Args[3:] { for _, override := range os.Args[3:] {
k, v := splitOverride(override) k, v := splitOverride(override)
overrides[k] = v overrides[k] = v
} }
for _, m := range metadata { for _, m := range metadata {
if strings.HasPrefix(version, fmt.Sprintf("v%d", m.Version)) { if int(m.Version) == packedActorsVersion {
// correct version
override, ok := overrides[m.Network] override, ok := overrides[m.Network]
if ok { if ok {
m.BundleGitTag = override m.BundleGitTag = override
} else { } else {
m.BundleGitTag = os.Args[2] m.BundleGitTag = gitTag
} }
metadataSpecificVersion = append(metadataSpecificVersion, m) } else {
m.BundleGitTag = getOldGitTagFromEmbeddedMetadata(m)
} }
} }
metadata = metadataSpecificVersion
} }
fi, err := os.Create("./build/builtin_actors_gen.go") fi, err := os.Create("./build/builtin_actors_gen.go")
@ -85,3 +89,14 @@ func main() {
panic(err) panic(err)
} }
} }
func getOldGitTagFromEmbeddedMetadata(m *build.BuiltinActorsMetadata) string {
for _, v := range build.EmbeddedBuiltinActorsMetadata {
// if we agree on the manifestCid for the previously embedded metadata, use the previously set tag
if m.Version == v.Version && m.Network == v.Network && m.ManifestCid == v.ManifestCid {
return m.BundleGitTag
}
}
return ""
}