cerc-io/lotus
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

Parse input/output for delegate call + other smaller things

Browse Source
This commit is contained in:
Fridrik Asmundsson 2023-08-25 21:50:24 +00:00
parent 029a4a72b8
commit ed407689e6
2 changed files with 44 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
chain/types/ethtypes/eth_types.go
View File

@ -938,7 +938,10 @@ type EthTrace struct {
TraceAddress []int `json:"traceAddress"` TraceAddress []int `json:"traceAddress"`
Type string `json:"Type"` Type string `json:"Type"`
Parent *EthTrace `json:"-"` Parent *EthTrace `json:"-"`
// if a subtrace makes a call to GetBytecode, we store a pointer to that subtrace here
// which we then lookup when checking for delegatecall (InvokeContractDelegate)
LastByteCode *EthTrace `json:"-"` LastByteCode *EthTrace `json:"-"`
} }

65
node/impl/full/eth_trace.go
View File

@ -13,6 +13,7 @@ import (
"github.com/filecoin-project/go-state-types/abi" "github.com/filecoin-project/go-state-types/abi"
"github.com/filecoin-project/go-state-types/builtin" "github.com/filecoin-project/go-state-types/builtin"
"github.com/filecoin-project/go-state-types/builtin/v10/evm"
"github.com/filecoin-project/go-state-types/exitcode" "github.com/filecoin-project/go-state-types/exitcode"
builtinactors "github.com/filecoin-project/lotus/chain/actors/builtin" builtinactors "github.com/filecoin-project/lotus/chain/actors/builtin"
@ -192,37 +193,51 @@ func buildTraces(ctx context.Context, traces *[]*ethtypes.EthTrace, parent *etht
} }
} }
// Handle delegate calls if builtinactors.IsEvmActor(parent.Action.FilecoinCodeCid) {
// // Handle delegate calls
// 1) Look for trace from an EVM actor to itself on InvokeContractDelegate, method 6.
// 2) Check that the previous trace calls another actor on method 3 (GetByteCode) and they are at the same level (same parent)
// 3) Treat this as a delegate call to actor A.
if parent.LastByteCode != nil && trace.Action.From == trace.Action.To &&
trace.Action.FilecoinMethod == builtin.MethodsEVM.InvokeContractDelegate {
log.Debugf("COND7 found delegate call, height: %d", height)
prev := parent.LastByteCode
if prev.Action.From == trace.Action.From && prev.Action.FilecoinMethod == builtin.MethodsEVM.GetBytecode && prev.Parent == trace.Parent {
trace.SetCallType("delegatecall")
trace.Action.To = prev.Action.To
}
} else {
// Handle EVM call special casing
// //
// Any outbound call from an EVM actor on methods 1-1023 are side-effects from EVM instructions // 1) Look for trace from an EVM actor to itself on InvokeContractDelegate, method 6.
// and should be dropped from the trace. // 2) Check that the previous trace calls another actor on method 3 (GetByteCode) and they are at the same level (same parent)
if builtinactors.IsEvmActor(parent.Action.FilecoinCodeCid) && // 3) Treat this as a delegate call to actor A.
et.Msg.Method > 0 && if parent.LastByteCode != nil && trace.Action.From == trace.Action.To &&
et.Msg.Method <= 1023 { trace.Action.FilecoinMethod == builtin.MethodsEVM.InvokeContractDelegate {
log.Debugf("COND5 found outbound call from an EVM actor on method 1-1023 method:%d, code:%s, height:%d", et.Msg.Method, parent.Action.FilecoinCodeCid.String(), height) log.Debugf("COND7 found delegate call, height: %d", height)
prev := parent.LastByteCode
if prev.Action.From == trace.Action.From && prev.Action.FilecoinMethod == builtin.MethodsEVM.GetBytecode && prev.Parent == trace.Parent {
trace.SetCallType("delegatecall")
trace.Action.To = prev.Action.To
if et.Msg.Method == builtin.MethodsEVM.GetBytecode { var dp evm.DelegateCallParams
// save the last bytecode trace to handle delegate calls err := dp.UnmarshalCBOR(bytes.NewReader(et.Msg.Params))
parent.LastByteCode = trace if err != nil {
return xerrors.Errorf("failed UnmarshalCBOR: %w", err)
}
trace.Action.Input = dp.Input
trace.Result.Output, err = decodePayload(et.MsgRct.Return, et.MsgRct.ReturnCodec)
if err != nil {
return xerrors.Errorf("failed decodePayload: %w", err)
}
} }
} else {
// Handle EVM call special casing
//
// Any outbound call from an EVM actor on methods 1-1023 are side-effects from EVM instructions
// and should be dropped from the trace.
if et.Msg.Method > 0 &&
et.Msg.Method <= 1023 {
log.Debugf("Infof found outbound call from an EVM actor on method 1-1023 method:%d, code:%s, height:%d", et.Msg.Method, parent.Action.FilecoinCodeCid.String(), height)
return nil if et.Msg.Method == builtin.MethodsEVM.GetBytecode {
// save the last bytecode trace to handle delegate calls
parent.LastByteCode = trace
}
return nil
}
} }
} }
} }
// we are adding trace to the traces so update the parent subtraces count as it was originally set to zero // we are adding trace to the traces so update the parent subtraces count as it was originally set to zero