From eae1851aaf6b847907bfdc97fc46776134e3aca3 Mon Sep 17 00:00:00 2001 From: Jakub Sztandera Date: Mon, 8 Jul 2019 17:36:24 +0200 Subject: [PATCH] Run docstring lint in seprate job License: MIT Signed-off-by: Jakub Sztandera --- .circleci/config.yml | 12 +++++++++--- .golangci.yml | 1 + 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index f6dd29131..bb8fe945c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -98,13 +98,18 @@ jobs: default: go/circleci-golang golangci-lint-version: type: string - default: 1.15.0 + default: 1.17.1 concurrency: type: string default: '2' description: | Concurrency used to run linters. Defaults to 2 because NumCPU is not aware of container CPU limits. + args: + type: string + default: '' + description: | + Arguments to pass to golangci-lint executor: << parameters.executor >> steps: - install-deps @@ -118,15 +123,16 @@ jobs: name: Lint command: | golangci-lint run -v \ - --concurrency << parameters.concurrency >> + --concurrency << parameters.concurrency >> << parameters.args >> workflows: version: 2 ci: jobs: + - lint - lint: - golangci-lint-version: 1.17.1 + args: "--no-config --exclude-use-default=false --disable-all --enable golint" - test: codecov-upload: true - mod-tidy-check diff --git a/.golangci.yml b/.golangci.yml index 8f25233e6..5ceae9812 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -20,6 +20,7 @@ issues: exclude: - "func name will be used as test\\.Test.* by other packages, and that stutters; consider calling this" - "Potential file inclusion via variable" + - "should have comment or be unexported" exclude-use-default: false exclude-rules: