cerc-io/lotus
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

The linter is *so* dumb:

Browse Source 
- There is no way for me to check the error on defer ...Close(), why even ask?
- A sort function does not suffer arbitrary aliasing

Everything is terrible...
This commit is contained in:
Peter Rabbitson 2020-11-23 06:51:52 +01:00
parent 2609342356
commit e7f3554c62
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/lotus-shed/sr2-dealstats-rollup.go
View File

@ -142,7 +142,7 @@ var rollupDealStatsCmd = &cli.Command{
if err != nil { if err != nil {
return err return err
} }
defer resp.Body.Close() defer resp.Body.Close() //nolint:errcheck
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
return xerrors.Errorf("non-200 response: %d", resp.StatusCode) return xerrors.Errorf("non-200 response: %d", resp.StatusCode)
@ -164,7 +164,7 @@ var rollupDealStatsCmd = &cli.Command{
if _, err := projListFh.Seek(0, 0); err != nil { if _, err := projListFh.Seek(0, 0); err != nil {
return err return err
} }
defer projListFh.Close() defer projListFh.Close() //nolint:errcheck
projList, err := gabs.ParseJSONBuffer(projListFh) projList, err := gabs.ParseJSONBuffer(projListFh)
if err != nil { if err != nil {
@ -192,19 +192,19 @@ var rollupDealStatsCmd = &cli.Command{
if err != nil { if err != nil {
return err return err
} }
defer outClientStatsFd.Close() defer outClientStatsFd.Close() //nolint:errcheck
outBasicStatsFd, err := os.Create(outDirName + "/basic_stats.json") outBasicStatsFd, err := os.Create(outDirName + "/basic_stats.json")
if err != nil { if err != nil {
return err return err
} }
defer outBasicStatsFd.Close() defer outBasicStatsFd.Close() //nolint:errcheck
outUnfilteredStatsFd, err := os.Create(outDirName + "/unfiltered_basic_stats.json") outUnfilteredStatsFd, err := os.Create(outDirName + "/unfiltered_basic_stats.json")
if err != nil { if err != nil {
return err return err
} }
defer outUnfilteredStatsFd.Close() defer outUnfilteredStatsFd.Close() //nolint:errcheck
api, apiCloser, err := lcli.GetFullNodeAPI(cctx) api, apiCloser, err := lcli.GetFullNodeAPI(cctx)
if err != nil { if err != nil {
@ -339,9 +339,10 @@ var rollupDealStatsCmd = &cli.Command{
return err return err
} }
defer outListFd.Close() defer outListFd.Close() //nolint:errcheck
sort.Slice(dl, func(i, j int) bool { sort.Slice(dl, func(i, j int) bool {
dl := dl
return dl[j].PaddedSize < dl[i].PaddedSize return dl[j].PaddedSize < dl[i].PaddedSize
}) })