From e1b69f84d6c623c6624bb34ba2c0f1c2a92ae90c Mon Sep 17 00:00:00 2001 From: Fridrik Asmundsson Date: Sat, 27 May 2023 10:25:56 +0000 Subject: [PATCH] Cleanup after removing urface upgrade --- cmd/lotus-bench/main.go | 1 - cmd/lotus-bench/rpc.go | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cmd/lotus-bench/main.go b/cmd/lotus-bench/main.go index 74d30115e..883f27a42 100644 --- a/cmd/lotus-bench/main.go +++ b/cmd/lotus-bench/main.go @@ -108,7 +108,6 @@ func main() { importBenchCmd, rpcCmd, }, - DisableSliceFlagSeparator: true, } if err := app.Run(os.Args); err != nil { diff --git a/cmd/lotus-bench/rpc.go b/cmd/lotus-bench/rpc.go index 1b3d1dadd..5da784c6e 100644 --- a/cmd/lotus-bench/rpc.go +++ b/cmd/lotus-bench/rpc.go @@ -41,7 +41,9 @@ Here are some real examples: lotus-bench rpc --method='eth_chainId::100' // override to 100 qps while using default concurrency lotus-bench rpc --method='eth_chainId:3:100' // run using 3 workers but limit to 100 qps lotus-bench rpc --method='eth_getTransactionCount:::["0xd4c70007F3F502f212c7e6794b94C06F36173B36", "latest"]' // run using optional params while using default concurrency and qps - lotus-bench rpc --method='eth_chainId' --method='eth_getTransactionCount:10:0:["0xd4c70007F3F502f212c7e6794b94C06F36173B36", "latest"]' // run multiple methods at once`, + lotus-bench rpc --method='eth_chainId' --method='eth_getTransactionCount:10:0:["0xd4c70007F3F502f212c7e6794b94C06F36173B36", "latest"]' // run multiple methods at once + +NOTE: The last two examples will not work until we upgrade urfave dependency (tracked in https://github.com/urfave/cli/issues/1734)`, Flags: []cli.Flag{ &cli.StringFlag{ Name: "endpoint",