storage: paths: Review suggestions

Co-authored-by: Aayush Rajasekaran <arajasek94@gmail.com>
This commit is contained in:
Łukasz Magiera 2022-07-15 12:46:20 +02:00 committed by GitHub
parent ac2ea039b5
commit e1b02dd13d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -127,7 +127,7 @@ func (i *Index) StorageAttach(ctx context.Context, si storiface.StorageInfo, st
for id, typ := range si.AllowTypes {
_, err := storiface.TypeFromString(typ)
if err != nil {
// No need no hard-fail here, just warn the user
// No need to hard-fail here, just warn the user
// (note that even with all-invalid entries we'll deny all types, so nothing unexpected should enter the path)
hasConfigIsses = true
@ -148,7 +148,7 @@ func (i *Index) StorageAttach(ctx context.Context, si storiface.StorageInfo, st
for id, typ := range si.DenyTypes {
_, err := storiface.TypeFromString(typ)
if err != nil {
// No need no hard-fail here, just warn the user
// No need to hard-fail here, just warn the user
hasConfigIsses = true
if i.alerting != nil {