Move creating and opening file to json transport constructor

This commit is contained in:
Matija Petrunic 2021-09-16 15:22:18 +02:00
parent 515925a178
commit d067bc9f01
2 changed files with 9 additions and 5 deletions

View File

@ -4,7 +4,6 @@ import (
"context" "context"
"encoding/json" "encoding/json"
"net" "net"
"os"
"time" "time"
host "github.com/libp2p/go-libp2p-core/host" host "github.com/libp2p/go-libp2p-core/host"
@ -368,11 +367,11 @@ func GossipSub(in GossipIn) (service *pubsub.PubSub, err error) {
var transports []tracer.TracerTransport var transports []tracer.TracerTransport
if in.Cfg.JsonTracerFile != "" { if in.Cfg.JsonTracerFile != "" {
out, err := os.OpenFile(in.Cfg.JsonTracerFile, os.O_CREATE|os.O_APPEND|os.O_WRONLY, 0660) jsonTransport, err := tracer.NewJsonTracerTransport(in.Cfg.JsonTracerFile)
if err != nil { if err != nil {
return nil, err return nil, err
} }
jsonTransport := tracer.NewJsonTracerTransport(out)
transports = append(transports, jsonTransport) transports = append(transports, jsonTransport)
} }
if in.Cfg.ElasticSearchTracer != "" { if in.Cfg.ElasticSearchTracer != "" {

View File

@ -10,10 +10,15 @@ type jsonTracerTransport struct {
out *os.File out *os.File
} }
func NewJsonTracerTransport(out *os.File) TracerTransport { func NewJsonTracerTransport(file string) (TracerTransport, error) {
out, err := os.OpenFile(file, os.O_CREATE|os.O_APPEND|os.O_WRONLY, 0660)
if err != nil {
return nil, err
}
return &jsonTracerTransport{ return &jsonTracerTransport{
out: out, out: out,
} }, nil
} }
func (jtt *jsonTracerTransport) Transport(evt TracerTransportEvent) error { func (jtt *jsonTracerTransport) Transport(evt TracerTransportEvent) error {