From d0198536879f9a9e3163e659f95b09cff5377f96 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=81ukasz=20Magiera?= Date: Mon, 29 Nov 2021 21:29:00 +0100 Subject: [PATCH] review: Cleanup some comments Co-authored-by: Peter Rabbitson --- api/types.go | 6 ++++-- node/impl/client/client.go | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/api/types.go b/api/types.go index a8fd79739..b0db46054 100644 --- a/api/types.go +++ b/api/types.go @@ -215,8 +215,10 @@ type DagSpec struct { // - the matched graph must have a single root DataSelector *Selector - // ExportMerkleProof matches the path traversal when DataSelector is a textselector. - // Ignored when DataSelector is a json selector and in non-car retrieval + // ExportMerkleProof is applicable only when exporting to a CAR file via a path textselector + // When true, in addition to the selection target, the resulting CAR will contain every block along the + // path back to, and including the original root + // When false the resulting CAR contains only the blocks of the target subdag ExportMerkleProof bool } diff --git a/node/impl/client/client.go b/node/impl/client/client.go index ab0814f23..4b6903d94 100644 --- a/node/impl/client/client.go +++ b/node/impl/client/client.go @@ -780,8 +780,6 @@ func getDataSelector(dps *api.Selector, matchPath bool) (datamodel.Node, error) selspec, err := textselector.SelectorSpecFromPath( textselector.Expression(*dps), matchPath, - // URGH - this is a direct copy from https://github.com/filecoin-project/go-fil-markets/blob/v1.12.0/shared/selectors.go#L10-L16 - // Unable to use it because we need the SelectorSpec, and markets exposes just a reified node ssb.ExploreRecursive( selector.RecursionLimitNone(), ssb.ExploreUnion(ssb.Matcher(), ssb.ExploreAll(ssb.ExploreRecursiveEdge())),