cerc-io/lotus
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

Invert msg validation check to explicitly specify reject errors

Browse Source
This commit is contained in:
Shrenuj Bansal 2023-06-28 13:35:21 -04:00
parent a2431ff70a
commit be3281bdcf
2 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
chain/messagepool/messagepool.go
View File

@ -63,6 +63,9 @@ var MaxNonceGap = uint64(4)
const MaxMessageSize = 64 << 10 // 64KiB const MaxMessageSize = 64 << 10 // 64KiB
// NOTE: When adding a new error type, please make sure to add the new error type in
// func (mv *MessageValidator) Validate(ctx context.Context, pid peer.ID, msg *pubsub.Message)
// in /chain/sub/incoming.go
var ( var (
ErrMessageTooBig = errors.New("message too big") ErrMessageTooBig = errors.New("message too big")

18
chain/sub/incoming.go
View File

@ -350,22 +350,16 @@ func (mv *MessageValidator) Validate(ctx context.Context, pid peer.ID, msg *pubs
) )
recordFailure(ctx, metrics.MessageValidationFailure, "add") recordFailure(ctx, metrics.MessageValidationFailure, "add")
switch { switch {
case xerrors.Is(err, messagepool.ErrSoftValidationFailure): case xerrors.Is(err, messagepool.ErrMessageTooBig):
fallthrough fallthrough
case xerrors.Is(err, messagepool.ErrRBFTooLowPremium): case xerrors.Is(err, messagepool.ErrMessageValueTooHigh):
fallthrough fallthrough
case xerrors.Is(err, messagepool.ErrTooManyPendingMessages): case xerrors.Is(err, messagepool.ErrNotEnoughFunds):
fallthrough fallthrough
case xerrors.Is(err, messagepool.ErrNonceGap): case xerrors.Is(err, messagepool.ErrInvalidToAddr):
fallthrough
case xerrors.Is(err, messagepool.ErrGasFeeCapTooLow):
fallthrough
case xerrors.Is(err, messagepool.ErrNonceTooLow):
fallthrough
case xerrors.Is(err, messagepool.ErrExistingNonce):
return pubsub.ValidationIgnore
default:
return pubsub.ValidationReject return pubsub.ValidationReject
default:
return pubsub.ValidationIgnore
} }
} }