fix: make sure we start the publish timer before recording the time
Otherwise, our nice and deterministic test may keep repeatedly setting the time to _right_ before the timer fires.
This commit is contained in:
parent
16f8a35e76
commit
add699d238
@ -228,11 +228,15 @@ func (p *DealPublisher) waitForMoreDeals() {
|
|||||||
// Set a timeout to wait for more deals to arrive
|
// Set a timeout to wait for more deals to arrive
|
||||||
log.Infof("waiting publish deals queue period of %s before publishing", p.publishPeriod)
|
log.Infof("waiting publish deals queue period of %s before publishing", p.publishPeriod)
|
||||||
ctx, cancel := context.WithCancel(p.ctx)
|
ctx, cancel := context.WithCancel(p.ctx)
|
||||||
|
|
||||||
|
// Create the timer _before_ taking the current time so publishPeriod+timeout is always >=
|
||||||
|
// the actual timer timeout.
|
||||||
|
timer := build.Clock.Timer(p.publishPeriod)
|
||||||
|
|
||||||
p.publishPeriodStart = build.Clock.Now()
|
p.publishPeriodStart = build.Clock.Now()
|
||||||
p.cancelWaitForMoreDeals = cancel
|
p.cancelWaitForMoreDeals = cancel
|
||||||
|
|
||||||
go func() {
|
go func() {
|
||||||
timer := build.Clock.Timer(p.publishPeriod)
|
|
||||||
select {
|
select {
|
||||||
case <-ctx.Done():
|
case <-ctx.Done():
|
||||||
timer.Stop()
|
timer.Stop()
|
||||||
|
Loading…
Reference in New Issue
Block a user