diff --git a/api/permissioned.go b/api/permissioned.go index eee6d330d..58d027278 100644 --- a/api/permissioned.go +++ b/api/permissioned.go @@ -65,7 +65,7 @@ func permissionedAny(in interface{}, out interface{}) { field := rint.Type().Field(f) requiredPerm := Permission(field.Tag.Get("perm")) if requiredPerm == "" { - panic("missing 'perm' tag on " + field.Name) // is this okay? can this be used to crash the process? + panic("missing 'perm' tag on " + field.Name) // ok } // Validate perm tag @@ -77,7 +77,7 @@ func permissionedAny(in interface{}, out interface{}) { } } if !ok { - panic("unknown 'perm' tag on " + field.Name) // is this okay? can this be used to crash the process? + panic("unknown 'perm' tag on " + field.Name) // ok } fn := ra.MethodByName(field.Name) diff --git a/chain/types/signature.go b/chain/types/signature.go index f3a61327b..8d7182e12 100644 --- a/chain/types/signature.go +++ b/chain/types/signature.go @@ -56,6 +56,7 @@ func (s *Signature) TypeCode() int { case KTBLS: return IKTBLS default: + log.Errorf("called TypeCode on signature with unknown Type: %q", s.Type) return IKTUnknown } }