cerc-io/lotus
16
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

Merge pull request #10209 from filecoin-project/fix-check-backupfile

Browse Source 
fix: cli: error if backup file already exists
This commit is contained in:
Phi-rjan 2023-02-09 18:39:17 +01:00 committed by GitHub
commit 9848e0467e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cli/backup.go
View File

@ -61,6 +61,10 @@ func BackupCmd(repoFlag string, rt repo.RepoType, getApi BackupApiFn) *cli.Comma
return xerrors.Errorf("expanding file path: %w", err) return xerrors.Errorf("expanding file path: %w", err)
} }
if _, err := os.Stat(fpath); !os.IsNotExist(err) {
return xerrors.Errorf("backup file %s already exists. Overwriting it will corrupt the file, please specify another file name", fpath)
}
out, err := os.OpenFile(fpath, os.O_CREATE|os.O_WRONLY, 0644) out, err := os.OpenFile(fpath, os.O_CREATE|os.O_WRONLY, 0644)
if err != nil { if err != nil {
return xerrors.Errorf("opening backup file %s: %w", fpath, err) return xerrors.Errorf("opening backup file %s: %w", fpath, err)
@ -87,7 +91,12 @@ func BackupCmd(repoFlag string, rt repo.RepoType, getApi BackupApiFn) *cli.Comma
} }
defer closer() defer closer()
err = api.CreateBackup(ReqContext(cctx), cctx.Args().First()) backupPath := cctx.Args().First()
if _, err := os.Stat(backupPath); !os.IsNotExist(err) {
return xerrors.Errorf("backup file %s already exists. Overwriting it will corrupt the file, please specify another file name", backupPath)
}
err = api.CreateBackup(ReqContext(cctx), backupPath)
if err != nil { if err != nil {
return err return err
} }