From 966af80dc295bd7e9972f42e9764e61f2f235223 Mon Sep 17 00:00:00 2001 From: Rod Vagg Date: Mon, 26 Feb 2024 21:12:36 +1100 Subject: [PATCH] Document future API changes --- chain/types/actor_event.go | 5 +++++ node/modules/actorevent.go | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/chain/types/actor_event.go b/chain/types/actor_event.go index 8987b00cc..bf95189e1 100644 --- a/chain/types/actor_event.go +++ b/chain/types/actor_event.go @@ -29,6 +29,9 @@ type ActorEventFilter struct { // The height of the earliest tipset to include in the query. If empty, the query starts at the // last finalized tipset. + // NOTE: In a future upgrade, this will be strict when set and will result in an error if a filter + // cannot be fulfilled by the depth of history available in the node. Currently, the node will + // nott return an error, but will return starting from the epoch it has data for. FromHeight *abi.ChainEpoch `json:"fromHeight,omitempty"` // The height of the latest tipset to include in the query. If empty, the query ends at the @@ -45,6 +48,8 @@ type ActorEvent struct { Entries []EventEntry `json:"entries"` // Filecoin address of the actor that emitted this event. + // NOTE: In a future upgrade, this will change to always be an ID address. Currently this will be + // either the f4 address, or ID address if an f4 is not available for this actor. Emitter address.Address `json:"emitter"` // Reverted is set to true if the message that produced this event was reverted because of a network re-org diff --git a/node/modules/actorevent.go b/node/modules/actorevent.go index 1e790179c..5d695ab57 100644 --- a/node/modules/actorevent.go +++ b/node/modules/actorevent.go @@ -2,7 +2,6 @@ package modules import ( "context" - "fmt" "path/filepath" "time" @@ -141,8 +140,6 @@ func EventFilterManager(cfg config.FevmConfig) func(helpers.MetricsCtx, repo.Loc return idAddr, true } - fmt.Println("") - return *actor.Address, true },