From 9305eca97c3c94b2b9506e2ee0ad9250f8b32958 Mon Sep 17 00:00:00 2001 From: frrist Date: Wed, 13 May 2020 14:46:16 -0700 Subject: [PATCH] don't ignore transfer error in delete actor --- chain/vm/runtime.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/chain/vm/runtime.go b/chain/vm/runtime.go index bb8dc89c6..ebaf48f59 100644 --- a/chain/vm/runtime.go +++ b/chain/vm/runtime.go @@ -271,8 +271,9 @@ func (rt *Runtime) DeleteActor(addr address.Address) { panic(aerrors.Fatalf("failed to get actor: %s", err)) } if !act.Balance.IsZero() { - // TODO don't ignore this error? - rt.vm.transfer(rt.Message().Receiver(), builtin.BurntFundsActorAddr, act.Balance) + if err := rt.vm.transfer(rt.Message().Receiver(), builtin.BurntFundsActorAddr, act.Balance); err != nil { + panic(aerrors.Fatalf("failed to transfer balance to burnt funds actor: %s", err)) + } } if err := rt.state.DeleteActor(rt.Message().Receiver()); err != nil {