Skip some rpc conformance tests

This commit is contained in:
Ian Davis 2023-01-26 17:07:17 +00:00
parent daf90ff402
commit 916b8001b4

View File

@ -138,10 +138,13 @@ func TestEthOpenRPCConformance(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
defer closer() defer closer()
const skipUntilIssue10106 = "Skipped until https://github.com/filecoin-project/lotus/issues/10106 is addressed"
testCases := []struct { testCases := []struct {
method string method string
variant string // suffix applied to the test name to distinguish different variants of a method call variant string // suffix applied to the test name to distinguish different variants of a method call
call func(*ethAPIRaw) (json.RawMessage, error) call func(*ethAPIRaw) (json.RawMessage, error)
skipReason string
}{ }{
// Alphabetical order // Alphabetical order
@ -223,6 +226,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetBlockByHash(context.Background(), blockHashWithMessage, true) return ethapi.EthGetBlockByHash(context.Background(), blockHashWithMessage, true)
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -231,6 +235,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetBlockByNumber(context.Background(), "earliest", true) return ethapi.EthGetBlockByNumber(context.Background(), "earliest", true)
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -239,6 +244,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetBlockByNumber(context.Background(), "pending", true) return ethapi.EthGetBlockByNumber(context.Background(), "pending", true)
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -246,6 +252,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetBlockByNumber(context.Background(), blockNumberWithMessage.Hex(), true) return ethapi.EthGetBlockByNumber(context.Background(), blockNumberWithMessage.Hex(), true)
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -321,6 +328,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetTransactionByBlockHashAndIndex(context.Background(), blockHashWithMessage, ethtypes.EthUint64(0)) return ethapi.EthGetTransactionByBlockHashAndIndex(context.Background(), blockHashWithMessage, ethtypes.EthUint64(0))
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -328,6 +336,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetTransactionByBlockNumberAndIndex(context.Background(), blockNumberWithMessage, ethtypes.EthUint64(0)) return ethapi.EthGetTransactionByBlockNumberAndIndex(context.Background(), blockNumberWithMessage, ethtypes.EthUint64(0))
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -335,6 +344,7 @@ func TestEthOpenRPCConformance(t *testing.T) {
call: func(a *ethAPIRaw) (json.RawMessage, error) { call: func(a *ethAPIRaw) (json.RawMessage, error) {
return ethapi.EthGetTransactionByHash(context.Background(), &messageWithEvents) return ethapi.EthGetTransactionByHash(context.Background(), &messageWithEvents)
}, },
skipReason: skipUntilIssue10106,
}, },
{ {
@ -401,6 +411,10 @@ func TestEthOpenRPCConformance(t *testing.T) {
name += "_" + tc.variant name += "_" + tc.variant
} }
t.Run(name, func(t *testing.T) { t.Run(name, func(t *testing.T) {
if tc.skipReason != "" {
t.Skipf(tc.skipReason)
}
schema, ok := schemas[tc.method] schema, ok := schemas[tc.method]
require.True(t, ok, "method not found in openrpc spec") require.True(t, ok, "method not found in openrpc spec")