snapdeals cleanup: address review

itests/kit/node_miner.go

@@ -225,6 +225,8 @@ func (tm *TestMiner) SectorsListNonGenesis(ctx context.Context) ([]abi.SectorNum
 	return l[tm.PresealSectors:], nil
 }
 
+// comes from https://github.com/filecoin-project/lotus/blob/8ba4355cabd25e5f65261aaa561ff676321ffbd8/storage/sealer/manager.go#L1226
+// todo: have this defined in one place
 type SchedInfo struct {
 	CallToWork   struct{}
 	EarlyRet     interface{}

itests/worker_upgrade_test.go

@@ -92,7 +92,7 @@ func TestWorkerUpgradeAbortCleanup(t *testing.T) {
 			case id == wpaths[0].ID: // worker path
 				if workers != storiface.FTNone {
 					require.Len(t, decls, 1)
-					require.EqualValues(t, decls[0].SectorFileType.Strings(), workers.Strings())
+					require.EqualValues(t, workers.Strings(), decls[0].SectorFileType.Strings())
 				} else {
 					require.Len(t, decls, 0)
 				}
@@ -101,7 +101,7 @@ func TestWorkerUpgradeAbortCleanup(t *testing.T) {
 			default: // miner path
 				if miners != storiface.FTNone {
 					require.Len(t, decls, 1)
-					require.EqualValues(t, decls[0].SectorFileType.Strings(), miners.Strings())
+					require.EqualValues(t, miners.Strings(), decls[0].SectorFileType.Strings())
 				} else {
 					require.Len(t, decls, 0)
 				}