cerc-io/lotus
16
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

fix: left pad log values to full EVM words.

Browse Source
This commit is contained in:
Raúl Kripalani 2022-11-16 22:08:19 +00:00
parent 23007b0b3b
commit 7a71ce48f4
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
node/impl/full/eth.go
View File

@ -1058,7 +1058,7 @@ func ethFilterResultFromEvents(evs []*filter.CollectedEvent) (*api.EthFilterResu
var err error
for _, entry := range ev.Entries {
value := api.EthBytes(decodeLogBytes(entry.Value))
value := api.EthBytes(leftpad32(decodeLogBytes(entry.Value)))
if entry.Key == api.EthTopic1 || entry.Key == api.EthTopic2 || entry.Key == api.EthTopic3 || entry.Key == api.EthTopic4 {
log.Topics = append(log.Topics, value)
} else {
@ -1499,7 +1499,7 @@ func newEthTxReceipt(ctx context.Context, tx api.EthTx, lookup *api.MsgLookup, r
}
for _, entry := range evt.Entries {
value := api.EthBytes(decodeLogBytes(entry.Value))
value := api.EthBytes(leftpad32(decodeLogBytes(entry.Value)))
if entry.Key == api.EthTopic1 || entry.Key == api.EthTopic2 || entry.Key == api.EthTopic3 || entry.Key == api.EthTopic4 {
l.Topics = append(l.Topics, value)
} else {
@ -1546,3 +1546,17 @@ func decodeLogBytes(orig []byte) []byte {
}
return decoded
}
// TODO we could also emit full EVM words from the EVM runtime, but not doing so
// makes the contract slightly cheaper (and saves storage bytes), at the expense
// of having to left pad in the API, which is a pretty acceptable tradeoff at
// face value. There may be other protocol implications to consider.
func leftpad32(orig []byte) []byte {
needed := 32 - len(orig)
if needed <= 0 {
return orig
}
ret := make([]byte, 32)
copy(ret[needed:], orig)
return ret
}