cerc-io/lotus
16
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

fix: api: Length check the array sent to eth_feeHistory RPC (#11696)

Browse Source 
Co-authored-by: Rod Vagg <rod@vagg.org>
Co-authored-by: Steven Allen <steven@stebalien.com>
This commit is contained in:
parthshah1 2024-03-10 18:43:45 -07:00 committed by GitHub
parent d9a0040573
commit 7516aff220
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
node/impl/full/eth.go
View File

@ -41,6 +41,8 @@ import (
var ErrUnsupported = errors.New("unsupported method") var ErrUnsupported = errors.New("unsupported method")
const maxEthFeeHistoryRewardPercentiles = 100
type EthModuleAPI interface { type EthModuleAPI interface {
EthBlockNumber(ctx context.Context) (ethtypes.EthUint64, error) EthBlockNumber(ctx context.Context) (ethtypes.EthUint64, error)
EthAccounts(ctx context.Context) ([]ethtypes.EthAddress, error) EthAccounts(ctx context.Context) ([]ethtypes.EthAddress, error)
@ -689,6 +691,9 @@ func (a *EthModule) EthFeeHistory(ctx context.Context, p jsonrpc.RawParams) (eth
} }
rewardPercentiles := make([]float64, 0) rewardPercentiles := make([]float64, 0)
if params.RewardPercentiles != nil { if params.RewardPercentiles != nil {
if len(*params.RewardPercentiles) > maxEthFeeHistoryRewardPercentiles {
return ethtypes.EthFeeHistory{}, errors.New("length of the reward percentile array cannot be greater than 100")
}
rewardPercentiles = append(rewardPercentiles, *params.RewardPercentiles...) rewardPercentiles = append(rewardPercentiles, *params.RewardPercentiles...)
} }
for i, rp := range rewardPercentiles { for i, rp := range rewardPercentiles {