fix: eth: ensure that the event topics are non-nil

Even when empty.

fixes #10910
This commit is contained in:
Steven Allen 2023-06-12 09:48:30 -07:00
parent 5b31b79d58
commit 739d61c698
2 changed files with 4 additions and 1 deletions

View File

@ -1537,6 +1537,8 @@ func ethLogFromEvent(entries []types.EventEntry) (data []byte, topics []ethtypes
topicsFoundCount int
dataFound bool
)
// Topics must be non-nil, even if empty. So we might as well pre-allocate for 4 (the max).
topics = make([]ethtypes.EthHash, 0, 4)
for _, entry := range entries {
// Drop events with non-raw topics to avoid mistakes.
if entry.Codec != cid.Raw {

View File

@ -17,7 +17,8 @@ func TestEthLogFromEvent(t *testing.T) {
data, topics, ok := ethLogFromEvent(nil)
require.True(t, ok)
require.Nil(t, data)
require.Nil(t, topics)
require.Empty(t, topics)
require.NotNil(t, topics)
// basic topic
data, topics, ok = ethLogFromEvent([]types.EventEntry{{