cerc-io/lotus
16
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

fix: api: return errors on failure to lookup an eth txn receipt (#11329)

Browse Source 
All these cases here are actually errors and returning `nil` makes this
hard to debug. We likely returned nil in the past to be "best effort"
but, as far as I can tell, we should only hit these error cases if
something is actually wrong.

part of #11325
This commit is contained in:
Steven Allen 2023-10-24 12:13:45 -07:00 committed by GitHub
parent 84b07519c2
commit 6e22c08c1d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
node/impl/full/eth.go
View File

@ -397,26 +397,31 @@ func (a *EthModule) EthGetTransactionReceiptLimited(ctx context.Context, txHash
} }
msgLookup, err := a.StateAPI.StateSearchMsg(ctx, types.EmptyTSK, c, limit, true) msgLookup, err := a.StateAPI.StateSearchMsg(ctx, types.EmptyTSK, c, limit, true)
if err != nil || msgLookup == nil { if err != nil {
return nil, xerrors.Errorf("failed to lookup Eth Txn %s as %s: %w", txHash, c, err)
}
if msgLookup == nil {
// This is the best we can do. In theory, we could have just not indexed this
// transaction, but there's no way to check that here.
return nil, nil return nil, nil
} }
tx, err := newEthTxFromMessageLookup(ctx, msgLookup, -1, a.Chain, a.StateAPI) tx, err := newEthTxFromMessageLookup(ctx, msgLookup, -1, a.Chain, a.StateAPI)
if err != nil { if err != nil {
return nil, nil return nil, xerrors.Errorf("failed to convert %s into an Eth Txn: %w", txHash, err)
} }
var events []types.Event var events []types.Event
if rct := msgLookup.Receipt; rct.EventsRoot != nil { if rct := msgLookup.Receipt; rct.EventsRoot != nil {
events, err = a.ChainAPI.ChainGetEvents(ctx, *rct.EventsRoot) events, err = a.ChainAPI.ChainGetEvents(ctx, *rct.EventsRoot)
if err != nil { if err != nil {
return nil, nil return nil, xerrors.Errorf("failed get events for %s", txHash)
} }
} }
receipt, err := newEthTxReceipt(ctx, tx, msgLookup, events, a.Chain, a.StateAPI) receipt, err := newEthTxReceipt(ctx, tx, msgLookup, events, a.Chain, a.StateAPI)
if err != nil { if err != nil {
return nil, nil return nil, xerrors.Errorf("failed to convert %s into an Eth Receipt: %w", txHash, err)
} }
return &receipt, nil return &receipt, nil