Address some review comments
This commit is contained in:
parent
37a7ee08ec
commit
5811f18b5e
@ -120,7 +120,6 @@ func (c *Client) Start(ctx context.Context, data cid.Cid, totalPrice types.BigIn
|
|||||||
Payment: PaymentInfo{
|
Payment: PaymentInfo{
|
||||||
PayChActor: address.Address{},
|
PayChActor: address.Address{},
|
||||||
Payer: address.Address{},
|
Payer: address.Address{},
|
||||||
Channel: 0,
|
|
||||||
ChannelMessage: dummyCid,
|
ChannelMessage: dummyCid,
|
||||||
Vouchers: nil,
|
Vouchers: nil,
|
||||||
},
|
},
|
||||||
|
@ -45,18 +45,17 @@ const (
|
|||||||
type PaymentInfo struct {
|
type PaymentInfo struct {
|
||||||
PayChActor address.Address
|
PayChActor address.Address
|
||||||
Payer address.Address
|
Payer address.Address
|
||||||
Channel uint64 // TODO: Not clear what that refers to, guessing something to do with multi-lane payments
|
|
||||||
ChannelMessage cid.Cid
|
ChannelMessage cid.Cid
|
||||||
|
|
||||||
Vouchers []actors.SignedVoucher
|
Vouchers []actors.SignedVoucher
|
||||||
}
|
}
|
||||||
|
|
||||||
type StorageDealProposal struct {
|
type StorageDealProposal struct {
|
||||||
PieceRef string // TODO: string per spec, but maybe should be a CID?
|
PieceRef string
|
||||||
SerializationMode SerializationMode
|
SerializationMode SerializationMode
|
||||||
CommP []byte
|
CommP []byte
|
||||||
|
|
||||||
Size uint64 // TODO: spec doesn't clearly specify the type
|
Size uint64
|
||||||
TotalPrice types.BigInt
|
TotalPrice types.BigInt
|
||||||
Duration uint64
|
Duration uint64
|
||||||
|
|
||||||
@ -73,12 +72,12 @@ type SignedStorageDealProposal struct {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// response
|
// response
|
||||||
|
|
||||||
type PieceInclusionProof struct {
|
type PieceInclusionProof struct {
|
||||||
Position uint // todo: type?
|
Position uint64
|
||||||
ProofElements [32]byte
|
ProofElements [32]byte
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: Spec says 'representation keyed', this is probably wrong
|
|
||||||
type StorageDealResponse struct {
|
type StorageDealResponse struct {
|
||||||
State DealState
|
State DealState
|
||||||
|
|
||||||
|
@ -86,7 +86,6 @@ var runCmd = &cli.Command{
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: Hello won't disconnect us because it only calls close in HandleStream when genesis doesn't match
|
|
||||||
if err := minerapi.NetConnect(ctx, remoteAddrs); err != nil {
|
if err := minerapi.NetConnect(ctx, remoteAddrs); err != nil {
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user