From ea82f554be244a546e09bc968b4d919b59f959b2 Mon Sep 17 00:00:00 2001 From: Mike Seiler Date: Tue, 7 Feb 2023 02:23:23 +0000 Subject: [PATCH 1/2] add bundle git tag from pack.sh into builtin_actors_gen --- Makefile | 2 +- build/actors/pack.sh | 2 +- build/builtin_actors.go | 9 +++++---- gen/bundle/bundle.go | 7 +++++++ 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/Makefile b/Makefile index 43c362b86..1598d8b61 100644 --- a/Makefile +++ b/Makefile @@ -298,7 +298,7 @@ actors-gen: actors-code-gen fiximports .PHONY: actors-gen bundle-gen: - $(GOCC) run ./gen/bundle + $(GOCC) run ./gen/bundle $(RELEASE) $(GOCC) fmt ./build/... .PHONY: bundle-gen diff --git a/build/actors/pack.sh b/build/actors/pack.sh index c2060e67c..863a3c5c7 100755 --- a/build/actors/pack.sh +++ b/build/actors/pack.sh @@ -52,4 +52,4 @@ popd echo "Generating metadata..." -make -C ../../ bundle-gen +make -C ../../ RELEASE="$RELEASE" bundle-gen diff --git a/build/builtin_actors.go b/build/builtin_actors.go index 4d283919e..50aecde40 100644 --- a/build/builtin_actors.go +++ b/build/builtin_actors.go @@ -95,10 +95,11 @@ func loadManifests(netw string) error { } type BuiltinActorsMetadata struct { - Network string - Version actorstypes.Version - ManifestCid cid.Cid - Actors map[string]cid.Cid + Network string + Version actorstypes.Version + ManifestCid cid.Cid + Actors map[string]cid.Cid + BundleGitTag string } // ReadEmbeddedBuiltinActorsMetadata reads the metadata from the embedded built-in actor bundles. diff --git a/gen/bundle/bundle.go b/gen/bundle/bundle.go index c7655157e..666ce9f66 100644 --- a/gen/bundle/bundle.go +++ b/gen/bundle/bundle.go @@ -20,6 +20,7 @@ var EmbeddedBuiltinActorsMetadata []*BuiltinActorsMetadata = []*BuiltinActorsMet {{- range . }} { Network: {{printf "%q" .Network}}, Version: {{.Version}}, + {{if .BundleGitTag}} BundleGitTag: {{printf "%q" .BundleGitTag}}, {{end}} ManifestCid: MustParseCid({{printf "%q" .ManifestCid}}), Actors: map[string]cid.Cid { {{- range $name, $cid := .Actors }} @@ -37,6 +38,12 @@ func main() { panic(err) } + if len(os.Args) > 1 { + for _, m := range metadata { + m.BundleGitTag = os.Args[1] + } + } + fi, err := os.Create("./build/builtin_actors_gen.go") if err != nil { panic(err) From 66d763ebc5e0dd344d51245463348acc5f1fd207 Mon Sep 17 00:00:00 2001 From: Mike Seiler Date: Wed, 8 Feb 2023 01:48:46 +0000 Subject: [PATCH 2/2] remove bundle-gen from make gen - not actually useful today anyway --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 1598d8b61..023ca61f5 100644 --- a/Makefile +++ b/Makefile @@ -354,7 +354,7 @@ docsgen-openrpc-gateway: docsgen-openrpc-bin fiximports: ./scripts/fiximports -gen: actors-code-gen type-gen cfgdoc-gen docsgen api-gen circleci bundle-gen fiximports +gen: actors-code-gen type-gen cfgdoc-gen docsgen api-gen circleci fiximports @echo ">>> IF YOU'VE MODIFIED THE CLI OR CONFIG, REMEMBER TO ALSO MAKE docsgen-cli" .PHONY: gen