Fix double locking

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protocol.ai>

node/builder.go

@@ -294,52 +294,40 @@ func ConfigFullNode(cfg *config.FullNode) Option {
 	)
 }
 
-func repoFull(r repo.Repo) Option {
+func configFull(c interface{}) Option {
-	lr, err := r.Lock(repo.RepoFullNode)
-	if err != nil {
-		return Error(err)
-	}
-	c, err := lr.Config()
-	if err != nil {
-		return Error(err)
-	}
 	cfg, ok := c.(*config.FullNode)
 	if !ok {
 		return Error(xerrors.Errorf("invalid config from repo, got: %T", c))
 	}
 
-	return Options(
+	return ConfigFullNode(cfg)
-		ConfigFullNode(cfg),
-		Override(new(repo.LockedRepo), modules.LockedRepo(lr)), // module handles closing
-	)
-}
-
-func repoMiner(r repo.Repo) Option {
-	lr, err := r.Lock(repo.RepoStorageMiner)
-	if err != nil {
-		return Error(err)
-	}
-	c, err := lr.Config()
-	if err != nil {
-		return Error(err)
 }
 
+func configMiner(c interface{}) Option {
 	cfg, ok := c.(*config.StorageMiner)
 	if !ok {
 		return Error(xerrors.Errorf("invalid config from repo, got: %T", c))
 	}
 
-	return Options(
+	return ConfigCommon(&cfg.Common)
-		ConfigCommon(&cfg.Common),
-		Override(new(repo.LockedRepo), modules.LockedRepo(lr)), // module handles closing
-	)
 }
 
 func Repo(r repo.Repo) Option {
+	return func(settings *Settings) error {
+		lr, err := r.Lock(settings.nodeType)
+		if err != nil {
+			return err
+		}
+		c, err := lr.Config()
+		if err != nil {
+			return err
+		}
 
 		return Options(
-		ApplyIf(isType(repo.RepoFullNode), repoFull(r)),
+			Override(new(repo.LockedRepo), modules.LockedRepo(lr)), // module handles closing
-		ApplyIf(isType(repo.RepoStorageMiner), repoMiner(r)),
+
+			ApplyIf(isType(repo.RepoFullNode), configFull(c)),
+			ApplyIf(isType(repo.RepoStorageMiner), configMiner(c)),
 
 			Override(new(dtypes.MetadataDS), modules.Datastore),
 			Override(new(dtypes.ChainBlockstore), modules.ChainBlockstore),
@@ -355,7 +343,8 @@ func Repo(r repo.Repo) Option {
 			Override(new(types.KeyStore), modules.KeyStore),
 
 			Override(new(*dtypes.APIAlg), modules.APISecret),
-	)
+		)(settings)
+	}
 }
 
 func FullAPI(out *api.FullNode) Option {