add comment about Signal unsoundness
This commit is contained in:
parent
371028a42a
commit
3cfbe3cd3f
@ -125,6 +125,8 @@ func (e *executionEnv) putToken(token *executionToken) {
|
|||||||
e.available++
|
e.available++
|
||||||
e.reserved += token.reserved
|
e.reserved += token.reserved
|
||||||
|
|
||||||
|
// Note: Signal is unsound, because a priority token could wake up a non-priority
|
||||||
|
// goroutnie and lead to deadlock. So Broadcast it must be.
|
||||||
e.cond.Broadcast()
|
e.cond.Broadcast()
|
||||||
|
|
||||||
metricsDown(metrics.VMExecutionRunning, token.lane)
|
metricsDown(metrics.VMExecutionRunning, token.lane)
|
||||||
|
Loading…
Reference in New Issue
Block a user