cerc-io/lotus
16
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

fix(events): don't log.Warn for EVM events with non-Raw codec (#11742)

Browse Source 
Codec != Raw likely means built-in actor events, which we can safely skip, so
avoid filling up logs with warnings for every built-in actor event that comes
past this point.

Fixes: https://github.com/filecoin-project/lotus/issues/11718
This commit is contained in:
Rod Vagg 2024-03-19 20:10:37 +11:00 committed by GitHub
parent 51b59e3b81
commit 2e75f3b796
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
node/impl/full/eth_events.go
View File

@ -39,9 +39,9 @@ func ethLogFromEvent(entries []types.EventEntry) (data []byte, topics []ethtypes
// Topics must be non-nil, even if empty. So we might as well pre-allocate for 4 (the max). // Topics must be non-nil, even if empty. So we might as well pre-allocate for 4 (the max).
topics = make([]ethtypes.EthHash, 0, 4) topics = make([]ethtypes.EthHash, 0, 4)
for _, entry := range entries { for _, entry := range entries {
// Drop events with non-raw topics to avoid mistakes. // Drop events with non-raw topics. Built-in actors emit CBOR, and anything else would be
// invalid anyway.
if entry.Codec != cid.Raw { if entry.Codec != cid.Raw {
log.Warnw("did not expect an event entry with a non-raw codec", "codec", entry.Codec, "key", entry.Key)
return nil, nil, false return nil, nil, false
} }
// Check if the key is t1..t4 // Check if the key is t1..t4