From e07438417cbb8eb93098a0e97ae40f3c6dbd5825 Mon Sep 17 00:00:00 2001
From: Anton Evangelatov <anton.evangelatov@gmail.com>
Date: Tue, 11 May 2021 13:19:26 +0200
Subject: [PATCH 1/2] consider storiface.PathStorage when calculating storage
 requirements

---
 extern/sector-storage/stores/index.go       | 10 +++++++++-
 extern/sector-storage/storiface/filetype.go | 18 ++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)

diff --git a/extern/sector-storage/stores/index.go b/extern/sector-storage/stores/index.go
index 4acc2ecdb..b4fe61a32 100644
--- a/extern/sector-storage/stores/index.go
+++ b/extern/sector-storage/stores/index.go
@@ -3,6 +3,7 @@ package stores
 import (
 	"context"
 	"errors"
+	"math"
 	"net/url"
 	gopath "path"
 	"sort"
@@ -383,7 +384,14 @@ func (i *Index) StorageBestAlloc(ctx context.Context, allocate storiface.SectorF
 
 	var candidates []storageEntry
 
-	spaceReq, err := allocate.SealSpaceUse(ssize)
+	var err error
+	spaceReq := uint64(math.MaxUint64)
+	switch pathType {
+	case storiface.PathSealing:
+		spaceReq, err = allocate.SealSpaceUse(ssize)
+	case storiface.PathStorage:
+		spaceReq, err = allocate.StoreSpaceUse(ssize)
+	}
 	if err != nil {
 		return nil, xerrors.Errorf("estimating required space: %w", err)
 	}
diff --git a/extern/sector-storage/storiface/filetype.go b/extern/sector-storage/storiface/filetype.go
index 3f7c7455e..2e0999022 100644
--- a/extern/sector-storage/storiface/filetype.go
+++ b/extern/sector-storage/storiface/filetype.go
@@ -73,6 +73,24 @@ func (t SectorFileType) SealSpaceUse(ssize abi.SectorSize) (uint64, error) {
 	return need, nil
 }
 
+func (t SectorFileType) StoreSpaceUse(ssize abi.SectorSize) (uint64, error) {
+	var need uint64
+	for _, pathType := range PathTypes {
+		if !t.Has(pathType) {
+			continue
+		}
+
+		oh, ok := FsOverheadFinalized[pathType]
+		if !ok {
+			return 0, xerrors.Errorf("no finalized overhead info for %s", pathType)
+		}
+
+		need += uint64(oh) * uint64(ssize) / FSOverheadDen
+	}
+
+	return need, nil
+}
+
 func (t SectorFileType) All() [FileTypes]bool {
 	var out [FileTypes]bool
 

From eb13c74dcea174284caa15b52be457f90ba54888 Mon Sep 17 00:00:00 2001
From: Anton Evangelatov <anton.evangelatov@gmail.com>
Date: Tue, 11 May 2021 18:14:01 +0200
Subject: [PATCH 2/2] panic on unknown pathType

---
 extern/sector-storage/stores/index.go | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/extern/sector-storage/stores/index.go b/extern/sector-storage/stores/index.go
index b4fe61a32..a84adf016 100644
--- a/extern/sector-storage/stores/index.go
+++ b/extern/sector-storage/stores/index.go
@@ -3,7 +3,7 @@ package stores
 import (
 	"context"
 	"errors"
-	"math"
+	"fmt"
 	"net/url"
 	gopath "path"
 	"sort"
@@ -385,12 +385,14 @@ func (i *Index) StorageBestAlloc(ctx context.Context, allocate storiface.SectorF
 	var candidates []storageEntry
 
 	var err error
-	spaceReq := uint64(math.MaxUint64)
+	var spaceReq uint64
 	switch pathType {
 	case storiface.PathSealing:
 		spaceReq, err = allocate.SealSpaceUse(ssize)
 	case storiface.PathStorage:
 		spaceReq, err = allocate.StoreSpaceUse(ssize)
+	default:
+		panic(fmt.Sprintf("unexpected pathType: %s", pathType))
 	}
 	if err != nil {
 		return nil, xerrors.Errorf("estimating required space: %w", err)