cerc-io/lotus
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

fix: check for unread params bytes in all cases (#10018)

Browse Source
This commit is contained in:
Steven Allen 2023-01-14 15:45:19 -08:00 committed by GitHub
parent 5372ab907f
commit 2a3989e4bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
chain/types/ethtypes/eth_transactions.go
View File

@ -104,9 +104,6 @@ func EthTxArgsFromMessage(msg *types.Message) (EthTxArgs, error) {
return EthTxArgs{}, xerrors.Errorf("failed to read params byte array: %w", err) return EthTxArgs{}, xerrors.Errorf("failed to read params byte array: %w", err)
} }
if paramsReader.Len() != 0 {
return EthTxArgs{}, xerrors.Errorf("extra data found in params")
}
if len(params) == 0 { if len(params) == 0 {
// Otherwise, we don't get a guaranteed round-trip. // Otherwise, we don't get a guaranteed round-trip.
return EthTxArgs{}, xerrors.Errorf("cannot invoke contracts with empty parameters from an eth-account") return EthTxArgs{}, xerrors.Errorf("cannot invoke contracts with empty parameters from an eth-account")
@ -114,6 +111,10 @@ func EthTxArgsFromMessage(msg *types.Message) (EthTxArgs, error) {
} }
} }
if paramsReader.Len() != 0 {
return EthTxArgs{}, xerrors.Errorf("extra data found in params")
}
return EthTxArgs{ return EthTxArgs{
ChainID: build.Eip155ChainId, ChainID: build.Eip155ChainId,
Nonce: int(msg.Nonce), Nonce: int(msg.Nonce),