From 25711c5ce4e18b7dac53ab82b42f5a7689cd8a83 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C5=81ukasz=20Magiera?= <magik6k@gmail.com>
Date: Sun, 17 Mar 2024 21:33:23 +0100
Subject: [PATCH] curio web: Task summaries in Cluster machines category

---
 curiosrc/web/hapi/simpleinfo.go               | 61 ++++++++++++++++++-
 curiosrc/web/hapi/web/cluster_machines.gohtml |  4 +-
 curiosrc/web/static/index.html                |  1 -
 .../sql/20240317-tasksummary-index.sql        |  3 +
 4 files changed, 66 insertions(+), 3 deletions(-)
 create mode 100644 lib/harmony/harmonydb/sql/20240317-tasksummary-index.sql

diff --git a/curiosrc/web/hapi/simpleinfo.go b/curiosrc/web/hapi/simpleinfo.go
index e639ef427..319db88e0 100644
--- a/curiosrc/web/hapi/simpleinfo.go
+++ b/curiosrc/web/hapi/simpleinfo.go
@@ -5,6 +5,7 @@ import (
 	"html/template"
 	"net/http"
 	"os"
+	"sort"
 	"sync"
 	"time"
 
@@ -107,10 +108,18 @@ func (a *app) executeTemplate(w http.ResponseWriter, name string, data interface
 	}
 }
 
+type machineRecentTask struct {
+	TaskName string
+	Success  int64
+	Fail     int64
+}
+
 type machineSummary struct {
 	Address      string
 	ID           int64
 	SinceContact string
+
+	RecentTasks []*machineRecentTask
 }
 
 type taskSummary struct {
@@ -133,7 +142,47 @@ type taskHistorySummary struct {
 }
 
 func (a *app) clusterMachineSummary(ctx context.Context) ([]machineSummary, error) {
-	rows, err := a.db.Query(ctx, "SELECT id, host_and_port, last_contact FROM harmony_machines")
+	// First get task summary for tasks completed in the last 24 hours
+	// NOTE: This query uses harmony_task_history_work_index, task history may get big
+	tsrows, err := a.db.Query(ctx, `SELECT hist.completed_by_host_and_port, hist.name, hist.result, count(1) FROM harmony_task_history hist
+	    WHERE hist.work_end > now() - INTERVAL '1 day'
+	    GROUP BY hist.completed_by_host_and_port, hist.name, hist.result
+	    ORDER BY completed_by_host_and_port ASC`)
+	if err != nil {
+		return nil, err
+	}
+	defer tsrows.Close()
+
+	// Map of machine -> task -> recent task
+	taskSummaries := map[string]map[string]*machineRecentTask{}
+
+	for tsrows.Next() {
+		var taskName string
+		var result bool
+		var count int64
+		var machine string
+
+		if err := tsrows.Scan(&machine, &taskName, &result, &count); err != nil {
+			return nil, err
+		}
+
+		if _, ok := taskSummaries[machine]; !ok {
+			taskSummaries[machine] = map[string]*machineRecentTask{}
+		}
+
+		if _, ok := taskSummaries[machine][taskName]; !ok {
+			taskSummaries[machine][taskName] = &machineRecentTask{TaskName: taskName}
+		}
+
+		if result {
+			taskSummaries[machine][taskName].Success = count
+		} else {
+			taskSummaries[machine][taskName].Fail = count
+		}
+	}
+
+	// Then machine summary
+	rows, err := a.db.Query(ctx, "SELECT id, host_and_port, last_contact FROM harmony_machines order by host_and_port asc")
 	if err != nil {
 		return nil, err // Handle error
 	}
@@ -150,6 +199,16 @@ func (a *app) clusterMachineSummary(ctx context.Context) ([]machineSummary, erro
 
 		m.SinceContact = time.Since(lastContact).Round(time.Second).String()
 
+		// Add recent tasks
+		if ts, ok := taskSummaries[m.Address]; ok {
+			for _, t := range ts {
+				m.RecentTasks = append(m.RecentTasks, t)
+			}
+			sort.Slice(m.RecentTasks, func(i, j int) bool {
+				return m.RecentTasks[i].TaskName < m.RecentTasks[j].TaskName
+			})
+		}
+
 		summaries = append(summaries, m)
 	}
 	return summaries, nil
diff --git a/curiosrc/web/hapi/web/cluster_machines.gohtml b/curiosrc/web/hapi/web/cluster_machines.gohtml
index f94f53bf8..b253a0561 100644
--- a/curiosrc/web/hapi/web/cluster_machines.gohtml
+++ b/curiosrc/web/hapi/web/cluster_machines.gohtml
@@ -3,8 +3,10 @@
     <tr>
         <td>{{.Address}}</td>
         <td>{{.ID}}</td>
-        <td>todo</td>
         <td>{{.SinceContact}}</td>
+        {{range .RecentTasks}}
+            <td>{{.TaskName}}:{{.Success}}{{if ne 0 .Fail}}(<i class="{{if eq 0 .Success}}error{{else}}warning{{end}}">{{.Fail}}</i>){{end}}</td>
+        {{end}}
     </tr>
 {{end}}
 {{end}}
diff --git a/curiosrc/web/static/index.html b/curiosrc/web/static/index.html
index 4f9c21b50..f2f1c087c 100644
--- a/curiosrc/web/static/index.html
+++ b/curiosrc/web/static/index.html
@@ -59,7 +59,6 @@
             <tr>
                 <th>Host</th>
                 <th>ID</th>
-                <th>Config Layers</th>
                 <th>Last Contact</th>
             </tr>
             </thead>
diff --git a/lib/harmony/harmonydb/sql/20240317-tasksummary-index.sql b/lib/harmony/harmonydb/sql/20240317-tasksummary-index.sql
new file mode 100644
index 000000000..a5f907778
--- /dev/null
+++ b/lib/harmony/harmonydb/sql/20240317-tasksummary-index.sql
@@ -0,0 +1,3 @@
+/* Used for webui clusterMachineSummary */
+CREATE INDEX harmony_task_history_work_index
+	ON harmony_task_history (completed_by_host_and_port ASC, name ASC, result ASC, work_end DESC);