From e7b0fb3de34da7541d0ac756af3c396f590f22e3 Mon Sep 17 00:00:00 2001 From: Phi Date: Tue, 26 Sep 2023 08:22:25 +0200 Subject: [PATCH 1/3] Update todo in config Updates the TODO in the synthetic config. --- documentation/en/default-lotus-miner-config.toml | 6 +++--- node/config/doc_gen.go | 6 +++--- node/config/types.go | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/documentation/en/default-lotus-miner-config.toml b/documentation/en/default-lotus-miner-config.toml index 81087222f..6405e433f 100644 --- a/documentation/en/default-lotus-miner-config.toml +++ b/documentation/en/default-lotus-miner-config.toml @@ -666,9 +666,9 @@ # env var: LOTUS_SEALING_TERMINATEBATCHWAIT #TerminateBatchWait = "5m0s" - # UseSyntheticPoRep will reduce the amout of data held on disk in the WaitSeed phase to 32GiB - # at the cost of having to precompute the synthetic challenges. - # TODO: put estimated costs here + # UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. + # This is achieved by precomputing "synthetic" challenges from CommR. + # Note that this comes at a cost of additional computation to generate these synthetic challenges. # # type: bool # env var: LOTUS_SEALING_USESYNTHETICPOREP diff --git a/node/config/doc_gen.go b/node/config/doc_gen.go index 1dec5b061..0b9640614 100644 --- a/node/config/doc_gen.go +++ b/node/config/doc_gen.go @@ -1299,9 +1299,9 @@ Submitting a smaller number of prove commits per epoch would reduce the possibil Name: "UseSyntheticPoRep", Type: "bool", - Comment: `UseSyntheticPoRep will reduce the amout of data held on disk in the WaitSeed phase to 32GiB -at the cost of having to precompute the synthetic challenges. -TODO: put estimated costs here`, + Comment: `UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. +This is achieved by precomputing "synthetic" challenges from CommR. +Note that this comes at a cost of additional computation to generate these synthetic challenges.`, }, }, "Splitstore": []DocField{ diff --git a/node/config/types.go b/node/config/types.go index 4a57390a3..e41fd54fb 100644 --- a/node/config/types.go +++ b/node/config/types.go @@ -430,9 +430,9 @@ type SealingConfig struct { // todo TargetSectors - stop auto-pleding new sectors after this many sectors are sealed, default CC upgrade for deals sectors if above - // UseSyntheticPoRep will reduce the amout of data held on disk in the WaitSeed phase to 32GiB - // at the cost of having to precompute the synthetic challenges. - // TODO: put estimated costs here + // UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. + // This is achieved by precomputing "synthetic" challenges from CommR. + // Note that this comes at a cost of additional computation to generate these synthetic challenges. UseSyntheticPoRep bool } From 3d8324d0f8e5236cc47b5b542108e3cd6b31e44b Mon Sep 17 00:00:00 2001 From: Phi Date: Wed, 27 Sep 2023 08:59:40 +0100 Subject: [PATCH 2/3] Remove precomputing line Remove precomputing line --- documentation/en/default-lotus-miner-config.toml | 1 - node/config/doc_gen.go | 1 - node/config/types.go | 1 - 3 files changed, 3 deletions(-) diff --git a/documentation/en/default-lotus-miner-config.toml b/documentation/en/default-lotus-miner-config.toml index 6405e433f..f40d92fa5 100644 --- a/documentation/en/default-lotus-miner-config.toml +++ b/documentation/en/default-lotus-miner-config.toml @@ -667,7 +667,6 @@ #TerminateBatchWait = "5m0s" # UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. - # This is achieved by precomputing "synthetic" challenges from CommR. # Note that this comes at a cost of additional computation to generate these synthetic challenges. # # type: bool diff --git a/node/config/doc_gen.go b/node/config/doc_gen.go index 0b9640614..b9d0797b2 100644 --- a/node/config/doc_gen.go +++ b/node/config/doc_gen.go @@ -1300,7 +1300,6 @@ Submitting a smaller number of prove commits per epoch would reduce the possibil Type: "bool", Comment: `UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. -This is achieved by precomputing "synthetic" challenges from CommR. Note that this comes at a cost of additional computation to generate these synthetic challenges.`, }, }, diff --git a/node/config/types.go b/node/config/types.go index e41fd54fb..29148a6f9 100644 --- a/node/config/types.go +++ b/node/config/types.go @@ -431,7 +431,6 @@ type SealingConfig struct { // todo TargetSectors - stop auto-pleding new sectors after this many sectors are sealed, default CC upgrade for deals sectors if above // UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. - // This is achieved by precomputing "synthetic" challenges from CommR. // Note that this comes at a cost of additional computation to generate these synthetic challenges. UseSyntheticPoRep bool } From f0fce8f4a508e070e6e90fc72ad36b34dc834039 Mon Sep 17 00:00:00 2001 From: Phi Date: Mon, 2 Oct 2023 13:19:13 +0100 Subject: [PATCH 3/3] Remove sentence Remove sentence about additional computation costs --- documentation/en/default-lotus-miner-config.toml | 1 - node/config/doc_gen.go | 3 +-- node/config/types.go | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/documentation/en/default-lotus-miner-config.toml b/documentation/en/default-lotus-miner-config.toml index f40d92fa5..6f0b2aa7c 100644 --- a/documentation/en/default-lotus-miner-config.toml +++ b/documentation/en/default-lotus-miner-config.toml @@ -667,7 +667,6 @@ #TerminateBatchWait = "5m0s" # UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. - # Note that this comes at a cost of additional computation to generate these synthetic challenges. # # type: bool # env var: LOTUS_SEALING_USESYNTHETICPOREP diff --git a/node/config/doc_gen.go b/node/config/doc_gen.go index b9d0797b2..b3df012ea 100644 --- a/node/config/doc_gen.go +++ b/node/config/doc_gen.go @@ -1299,8 +1299,7 @@ Submitting a smaller number of prove commits per epoch would reduce the possibil Name: "UseSyntheticPoRep", Type: "bool", - Comment: `UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. -Note that this comes at a cost of additional computation to generate these synthetic challenges.`, + Comment: `UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB.`, }, }, "Splitstore": []DocField{ diff --git a/node/config/types.go b/node/config/types.go index 29148a6f9..78f2d1361 100644 --- a/node/config/types.go +++ b/node/config/types.go @@ -431,7 +431,6 @@ type SealingConfig struct { // todo TargetSectors - stop auto-pleding new sectors after this many sectors are sealed, default CC upgrade for deals sectors if above // UseSyntheticPoRep, when set to true, will reduce the amount of cache data held on disk after the completion of PreCommit 2 to 11GiB. - // Note that this comes at a cost of additional computation to generate these synthetic challenges. UseSyntheticPoRep bool }