cerc-io/lotus
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 27 Wiki Activity

fix: eth: remove trace sanity check (#11385)

Browse Source 
We added this check as a self-test to make sure that the message indices
in our trace matched up with those in the block. Unfortunately, this
only works for blocks on the main-chain, and breaks tracing of uncle
blocks (and tracing of head).
This commit is contained in:
Steven Allen 2023-11-17 18:08:58 +01:00 committed by GitHub
parent 87105b5121
commit 06d288e92b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
node/impl/full/eth.go
View File

@ -842,16 +842,6 @@ func (a *EthModule) EthTraceBlock(ctx context.Context, blkNum string) ([]*ethtyp
return nil, xerrors.Errorf("failed when calling ExecutionTrace: %w", err) return nil, xerrors.Errorf("failed when calling ExecutionTrace: %w", err)
} }
tsParent, err := a.ChainAPI.ChainGetTipSetByHeight(ctx, ts.Height()+1, a.Chain.GetHeaviestTipSet().Key())
if err != nil {
return nil, xerrors.Errorf("cannot get tipset at height: %v", ts.Height()+1)
}
msgs, err := a.ChainGetParentMessages(ctx, tsParent.Blocks()[0].Cid())
if err != nil {
return nil, xerrors.Errorf("failed to get parent messages: %w", err)
}
cid, err := ts.Key().Cid() cid, err := ts.Key().Cid()
if err != nil { if err != nil {
return nil, xerrors.Errorf("failed to get tipset key cid: %w", err) return nil, xerrors.Errorf("failed to get tipset key cid: %w", err)
@ -870,11 +860,6 @@ func (a *EthModule) EthTraceBlock(ctx context.Context, blkNum string) ([]*ethtyp
continue continue
} }
// as we include TransactionPosition in the results, lets do sanity checking that the
// traces are indeed in the message execution order
if ir.Msg.Cid() != msgs[msgIdx].Message.Cid() {
return nil, xerrors.Errorf("traces are not in message execution order")
}
msgIdx++ msgIdx++
txHash, err := a.EthGetTransactionHashByCid(ctx, ir.MsgCid) txHash, err := a.EthGetTransactionHashByCid(ctx, ir.MsgCid)