From 050a0ec5e4a593476f1cf21cb27e035c9fe2d4e7 Mon Sep 17 00:00:00 2001 From: lanzafame Date: Fri, 28 Aug 2020 17:01:45 +1000 Subject: [PATCH] further reduce code duplication --- chain/sub/incoming.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/chain/sub/incoming.go b/chain/sub/incoming.go index 5dd9d58e7..d0bca9792 100644 --- a/chain/sub/incoming.go +++ b/chain/sub/incoming.go @@ -546,10 +546,9 @@ func (mv *MessageValidator) Validate(ctx context.Context, pid peer.ID, msg *pubs log.Debugf("failed to add message from network to message pool (From: %s, To: %s, Nonce: %d, Value: %s): %s", m.Message.From, m.Message.To, m.Message.Nonce, types.FIL(m.Message.Value), err) ctx, _ = tag.New( ctx, - tag.Upsert(metrics.FailureType, "add"), tag.Upsert(metrics.Local, "false"), ) - stats.Record(ctx, metrics.MessageValidationFailure.M(1)) + recordFailure(ctx, metrics.MessageValidationFailure, "add") switch { case xerrors.Is(err, messagepool.ErrBroadcastAnyway): fallthrough @@ -630,4 +629,4 @@ func recordFailure(ctx context.Context, metric *stats.Int64Measure, failureType tag.Upsert(metrics.FailureType, failureType), ) stats.Record(ctx, metric.M(1)) -} \ No newline at end of file +}