lighthouse/testing
Paul Hauner fa6ad1a11a Deduplicate block root computation (#3590)
## Issue Addressed

NA

## Proposed Changes

This PR removes duplicated block root computation.

Computing the `SignedBeaconBlock::canonical_root` has become more expensive since the merge as we need to compute the merke root of each transaction inside an `ExecutionPayload`.

Computing the root for [a mainnet block](https://beaconcha.in/slot/4704236) is taking ~10ms on my i7-8700K CPU @ 3.70GHz (no sha extensions). Given that our median seen-to-imported time for blocks is presently 300-400ms, removing a few duplicated block roots (~30ms) could represent an easy 10% improvement. When we consider that the seen-to-imported times include operations *after* the block has been placed in the early attester cache, we could expect the 30ms to be more significant WRT our seen-to-attestable times.

## Additional Info

NA
2022-09-23 03:52:42 +00:00
..
antithesis Fix antithesis docker builds (#3380) 2022-07-28 07:40:03 +00:00
ef_tests Deduplicate block root computation (#3590) 2022-09-23 03:52:42 +00:00
eth1_test_rig Fix ganache test endpoint for ipv6 machines (#3563) 2022-09-13 01:57:45 +00:00
execution_engine_integration Unblock CI by updating git submodules directly in execution integration tests (#3479) 2022-08-19 04:27:20 +00:00
node_test_rig Add merge support to simulator (#3292) 2022-07-18 23:15:40 +00:00
simulator Add disable-log-timestamp flag (#3101) (#3586) 2022-09-23 03:52:41 +00:00
state_transition_vectors Fix lints for Rust 1.63 (#3459) 2022-08-12 00:56:39 +00:00
test-test_logger Update to Rust 1.59 and 2021 edition (#3038) 2022-02-25 00:10:17 +00:00
web3signer_tests Builder Specs v0.2.0 (#3134) 2022-07-30 00:22:37 +00:00