f77e3bc0ad
## Proposed Changes Add a new Cargo compilation profile called `maxperf` which enables more aggressive compiler optimisations at the expense of compilation time. Some rough initial benchmarks show that this can provide up to a 25% reduction to run time for CPU bound tasks like block processing: https://docs.google.com/spreadsheets/d/15jHuZe7lLHhZq9Nw8kc6EL0Qh_N_YAYqkW2NQ_Afmtk/edit The numbers in that spreadsheet compare the `consensus-context` branch from #3604 to the same branch compiled with the `maxperf` profile using: ``` PROFILE=maxperf make install-lcli ``` ## Additional Info The downsides of the maxperf profile are: - It increases compile times substantially, which will particularly impact low-spec hardware. Compiling `lcli` is about 3x slower. Compiling Lighthouse is about 5x slower on my 5950X: 17m 38s rather than 3m 28s. As a result I think we should not enable this everywhere by default. - **Option 1**: enable by default for our released binaries. This gives the majority of users the fastest version of `lighthouse` possible, at the expense of slowing down our release CI. Source builds will continue to use the default `release` profile unless users opt-in to `maxperf`. - **Option 2**: enable by default for source builds. This gives users building from source an edge, but makes them pay for it with compilation time. I think I would prefer Option 1. I'll try doing some benchmarking to see how long a maxperf build of Lighthouse would take on GitHub actions. Credit to Nicholas Nethercote for documenting these options in the Rust Performance Book: https://nnethercote.github.io/perf-book/build-configuration.html.
143 lines
6.4 KiB
YAML
143 lines
6.4 KiB
YAML
name: docker
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- unstable
|
|
- stable
|
|
tags:
|
|
- v*
|
|
|
|
env:
|
|
DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }}
|
|
DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }}
|
|
IMAGE_NAME: ${{ github.repository_owner}}/lighthouse
|
|
LCLI_IMAGE_NAME: ${{ github.repository_owner }}/lcli
|
|
|
|
jobs:
|
|
# Extract the VERSION which is either `latest` or `vX.Y.Z`, and the VERSION_SUFFIX
|
|
# which is either empty or `-unstable`.
|
|
#
|
|
# It would be nice if the arch didn't get spliced into the version between `latest` and
|
|
# `unstable`, but for now we keep the two parts of the version separate for backwards
|
|
# compatibility.
|
|
extract-version:
|
|
runs-on: ubuntu-18.04
|
|
steps:
|
|
- name: Extract version (if stable)
|
|
if: github.event.ref == 'refs/heads/stable'
|
|
run: |
|
|
echo "VERSION=latest" >> $GITHUB_ENV
|
|
echo "VERSION_SUFFIX=" >> $GITHUB_ENV
|
|
- name: Extract version (if unstable)
|
|
if: github.event.ref == 'refs/heads/unstable'
|
|
run: |
|
|
echo "VERSION=latest" >> $GITHUB_ENV
|
|
echo "VERSION_SUFFIX=-unstable" >> $GITHUB_ENV
|
|
- name: Extract version (if tagged release)
|
|
if: startsWith(github.event.ref, 'refs/tags')
|
|
run: |
|
|
echo "VERSION=$(echo ${GITHUB_REF#refs/tags/})" >> $GITHUB_ENV
|
|
echo "VERSION_SUFFIX=" >> $GITHUB_ENV
|
|
outputs:
|
|
VERSION: ${{ env.VERSION }}
|
|
VERSION_SUFFIX: ${{ env.VERSION_SUFFIX }}
|
|
build-docker-single-arch:
|
|
name: build-docker-${{ matrix.binary }}
|
|
runs-on: ubuntu-18.04
|
|
strategy:
|
|
matrix:
|
|
binary: [aarch64,
|
|
aarch64-portable,
|
|
x86_64,
|
|
x86_64-portable]
|
|
include:
|
|
- profile: maxperf
|
|
|
|
needs: [extract-version]
|
|
env:
|
|
# We need to enable experimental docker features in order to use `docker buildx`
|
|
DOCKER_CLI_EXPERIMENTAL: enabled
|
|
VERSION: ${{ needs.extract-version.outputs.VERSION }}
|
|
VERSION_SUFFIX: ${{ needs.extract-version.outputs.VERSION_SUFFIX }}
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- name: Update Rust
|
|
run: rustup update stable
|
|
- name: Dockerhub login
|
|
run: |
|
|
echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
|
|
- name: Cross build Lighthouse binary
|
|
run: |
|
|
cargo install cross
|
|
env CROSS_PROFILE=${{ matrix.profile }} make build-${{ matrix.binary }}
|
|
- name: Move cross-built binary into Docker scope (if ARM)
|
|
if: startsWith(matrix.binary, 'aarch64')
|
|
run: |
|
|
mkdir ./bin;
|
|
mv ./target/aarch64-unknown-linux-gnu/${{ matrix.profile }}/lighthouse ./bin;
|
|
- name: Move cross-built binary into Docker scope (if x86_64)
|
|
if: startsWith(matrix.binary, 'x86_64')
|
|
run: |
|
|
mkdir ./bin;
|
|
mv ./target/x86_64-unknown-linux-gnu/${{ matrix.profile }}/lighthouse ./bin;
|
|
- name: Map aarch64 to arm64 short arch
|
|
if: startsWith(matrix.binary, 'aarch64')
|
|
run: echo "SHORT_ARCH=arm64" >> $GITHUB_ENV
|
|
- name: Map x86_64 to amd64 short arch
|
|
if: startsWith(matrix.binary, 'x86_64')
|
|
run: echo "SHORT_ARCH=amd64" >> $GITHUB_ENV;
|
|
- name: Set modernity suffix
|
|
if: endsWith(matrix.binary, '-portable') != true
|
|
run: echo "MODERNITY_SUFFIX=-modern" >> $GITHUB_ENV;
|
|
# Install dependencies for emulation. Have to create a new builder to pick up emulation support.
|
|
- name: Build Dockerfile and push
|
|
run: |
|
|
docker run --privileged --rm tonistiigi/binfmt --install ${SHORT_ARCH}
|
|
docker buildx create --use --name cross-builder
|
|
docker buildx build \
|
|
--platform=linux/${SHORT_ARCH} \
|
|
--file ./Dockerfile.cross . \
|
|
--tag ${IMAGE_NAME}:${VERSION}-${SHORT_ARCH}${VERSION_SUFFIX}${MODERNITY_SUFFIX} \
|
|
--push
|
|
build-docker-multiarch:
|
|
name: build-docker-multiarch${{ matrix.modernity }}
|
|
runs-on: ubuntu-18.04
|
|
needs: [build-docker-single-arch, extract-version]
|
|
strategy:
|
|
matrix:
|
|
modernity: ["", "-modern"]
|
|
env:
|
|
# We need to enable experimental docker features in order to use `docker manifest`
|
|
DOCKER_CLI_EXPERIMENTAL: enabled
|
|
VERSION: ${{ needs.extract-version.outputs.VERSION }}
|
|
VERSION_SUFFIX: ${{ needs.extract-version.outputs.VERSION_SUFFIX }}
|
|
steps:
|
|
- name: Dockerhub login
|
|
run: |
|
|
echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
|
|
- name: Create and push multiarch manifest
|
|
run: |
|
|
docker manifest create ${IMAGE_NAME}:${VERSION}${VERSION_SUFFIX}${{ matrix.modernity }} \
|
|
--amend ${IMAGE_NAME}:${VERSION}-arm64${VERSION_SUFFIX}${{ matrix.modernity }} \
|
|
--amend ${IMAGE_NAME}:${VERSION}-amd64${VERSION_SUFFIX}${{ matrix.modernity }};
|
|
docker manifest push ${IMAGE_NAME}:${VERSION}${VERSION_SUFFIX}${{ matrix.modernity }}
|
|
build-docker-lcli:
|
|
runs-on: ubuntu-18.04
|
|
needs: [extract-version]
|
|
env:
|
|
VERSION: ${{ needs.extract-version.outputs.VERSION }}
|
|
VERSION_SUFFIX: ${{ needs.extract-version.outputs.VERSION_SUFFIX }}
|
|
steps:
|
|
- uses: actions/checkout@v2
|
|
- name: Dockerhub login
|
|
run: |
|
|
echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
|
|
- name: Build lcli dockerfile (with push)
|
|
run: |
|
|
docker build \
|
|
--build-arg PORTABLE=true \
|
|
--tag ${LCLI_IMAGE_NAME}:${VERSION}${VERSION_SUFFIX} \
|
|
--file ./lcli/Dockerfile .
|
|
docker push ${LCLI_IMAGE_NAME}:${VERSION}${VERSION_SUFFIX}
|