## Issue Addressed
NA
## Proposed Changes
- Introduces the `valdiator_definitions.yml` file which serves as an explicit list of validators that should be run by the validator client.
- Removes `--strict` flag, split into `--strict-lockfiles` and `--disable-auto-discover`
- Adds a "Validator Management" page to the book.
- Adds the `common/account_utils` crate which contains some logic that was starting to duplicate across the codebase.
The new docs for this feature are the best description of it (apart from the code, I guess): 9cb87e93ce/book/src/validator-management.md
## API Changes
This change should be transparent for *most* existing users. If the `valdiator_definitions.yml` doesn't exist then it will be automatically generated using a method that will detect all the validators in their `validators_dir`.
Users will have issues if they are:
1. Using `--strict`.
1. Have keystores in their `~/.lighthouse/validators` directory that weren't being detected by the current keystore discovery method.
For users with (1), the VC will refuse to start because the `--strict` flag has been removed. They will be forced to review `--help` and choose an equivalent flag.
For users with (2), this seems fairly unlikely and since we're only in testnets there's no *real* value on the line here. I'm happy to take the risk, it would be a different case for mainnet.
## Additional Info
This PR adds functionality we will need for #1347.
## TODO
- [x] Reconsider flags
- [x] Move doc into a more reasonable chapter.
- [x] Check for compile warnings.
332 lines
11 KiB
Rust
332 lines
11 KiB
Rust
use crate::{
|
|
config::{Config, SLASHING_PROTECTION_FILENAME},
|
|
fork_service::ForkService,
|
|
initialized_validators::InitializedValidators,
|
|
};
|
|
use parking_lot::RwLock;
|
|
use slashing_protection::{NotSafe, Safe, SlashingDatabase};
|
|
use slog::{crit, error, warn, Logger};
|
|
use slot_clock::SlotClock;
|
|
use std::marker::PhantomData;
|
|
use std::sync::Arc;
|
|
use tempdir::TempDir;
|
|
use types::{
|
|
Attestation, BeaconBlock, ChainSpec, Domain, Epoch, EthSpec, Fork, Hash256, Keypair, PublicKey,
|
|
SelectionProof, Signature, SignedAggregateAndProof, SignedBeaconBlock, SignedRoot, Slot,
|
|
};
|
|
use validator_dir::ValidatorDir;
|
|
|
|
struct LocalValidator {
|
|
validator_dir: ValidatorDir,
|
|
voting_keypair: Keypair,
|
|
}
|
|
|
|
/// We derive our own `PartialEq` to avoid doing equality checks between secret keys.
|
|
///
|
|
/// It's nice to avoid secret key comparisons from a security perspective, but it's also a little
|
|
/// risky when it comes to `HashMap` integrity (that's why we need `PartialEq`).
|
|
///
|
|
/// Currently, we obtain keypairs from keystores where we derive the `PublicKey` from a `SecretKey`
|
|
/// via a hash function. In order to have two equal `PublicKey` with different `SecretKey` we would
|
|
/// need to have either:
|
|
///
|
|
/// - A serious upstream integrity error.
|
|
/// - A hash collision.
|
|
///
|
|
/// It seems reasonable to make these two assumptions in order to avoid the equality checks.
|
|
impl PartialEq for LocalValidator {
|
|
fn eq(&self, other: &Self) -> bool {
|
|
self.validator_dir == other.validator_dir
|
|
&& self.voting_keypair.pk == other.voting_keypair.pk
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
pub struct ValidatorStore<T, E: EthSpec> {
|
|
validators: Arc<RwLock<InitializedValidators>>,
|
|
slashing_protection: SlashingDatabase,
|
|
genesis_validators_root: Hash256,
|
|
spec: Arc<ChainSpec>,
|
|
log: Logger,
|
|
temp_dir: Option<Arc<TempDir>>,
|
|
fork_service: ForkService<T, E>,
|
|
_phantom: PhantomData<E>,
|
|
}
|
|
|
|
impl<T: SlotClock + 'static, E: EthSpec> ValidatorStore<T, E> {
|
|
pub fn new(
|
|
validators: InitializedValidators,
|
|
config: &Config,
|
|
genesis_validators_root: Hash256,
|
|
spec: ChainSpec,
|
|
fork_service: ForkService<T, E>,
|
|
log: Logger,
|
|
) -> Result<Self, String> {
|
|
let slashing_db_path = config.data_dir.join(SLASHING_PROTECTION_FILENAME);
|
|
let slashing_protection =
|
|
SlashingDatabase::open_or_create(&slashing_db_path).map_err(|e| {
|
|
format!(
|
|
"Failed to open or create slashing protection database: {:?}",
|
|
e
|
|
)
|
|
})?;
|
|
|
|
Ok(Self {
|
|
validators: Arc::new(RwLock::new(validators)),
|
|
slashing_protection,
|
|
genesis_validators_root,
|
|
spec: Arc::new(spec),
|
|
log,
|
|
temp_dir: None,
|
|
fork_service,
|
|
_phantom: PhantomData,
|
|
})
|
|
}
|
|
|
|
/// Register all known validators with the slashing protection database.
|
|
///
|
|
/// Registration is required to protect against a lost or missing slashing database,
|
|
/// such as when relocating validator keys to a new machine.
|
|
pub fn register_all_validators_for_slashing_protection(&self) -> Result<(), String> {
|
|
self.slashing_protection
|
|
.register_validators(self.validators.read().iter_voting_pubkeys())
|
|
.map_err(|e| format!("Error while registering validators: {:?}", e))
|
|
}
|
|
|
|
pub fn voting_pubkeys(&self) -> Vec<PublicKey> {
|
|
self.validators
|
|
.read()
|
|
.iter_voting_pubkeys()
|
|
.cloned()
|
|
.collect()
|
|
}
|
|
|
|
pub fn num_voting_validators(&self) -> usize {
|
|
self.validators.read().num_enabled()
|
|
}
|
|
|
|
fn fork(&self) -> Option<Fork> {
|
|
if self.fork_service.fork().is_none() {
|
|
error!(
|
|
self.log,
|
|
"Unable to get Fork for signing";
|
|
);
|
|
}
|
|
self.fork_service.fork()
|
|
}
|
|
|
|
pub fn randao_reveal(&self, validator_pubkey: &PublicKey, epoch: Epoch) -> Option<Signature> {
|
|
// TODO: check this against the slot clock to make sure it's not an early reveal?
|
|
self.validators
|
|
.read()
|
|
.voting_keypair(validator_pubkey)
|
|
.and_then(|voting_keypair| {
|
|
let domain = self.spec.get_domain(
|
|
epoch,
|
|
Domain::Randao,
|
|
&self.fork()?,
|
|
self.genesis_validators_root,
|
|
);
|
|
let message = epoch.signing_root(domain);
|
|
|
|
Some(Signature::new(message.as_bytes(), &voting_keypair.sk))
|
|
})
|
|
}
|
|
|
|
pub fn sign_block(
|
|
&self,
|
|
validator_pubkey: &PublicKey,
|
|
block: BeaconBlock<E>,
|
|
current_slot: Slot,
|
|
) -> Option<SignedBeaconBlock<E>> {
|
|
// Make sure the block slot is not higher than the current slot to avoid potential attacks.
|
|
if block.slot > current_slot {
|
|
warn!(
|
|
self.log,
|
|
"Not signing block with slot greater than current slot";
|
|
"block_slot" => block.slot.as_u64(),
|
|
"current_slot" => current_slot.as_u64()
|
|
);
|
|
return None;
|
|
}
|
|
|
|
// Check for slashing conditions.
|
|
let fork = self.fork()?;
|
|
let domain = self.spec.get_domain(
|
|
block.epoch(),
|
|
Domain::BeaconProposer,
|
|
&fork,
|
|
self.genesis_validators_root,
|
|
);
|
|
|
|
let slashing_status = self.slashing_protection.check_and_insert_block_proposal(
|
|
validator_pubkey,
|
|
&block.block_header(),
|
|
domain,
|
|
);
|
|
|
|
match slashing_status {
|
|
// We can safely sign this block.
|
|
Ok(Safe::Valid) => {
|
|
let validators = self.validators.read();
|
|
let voting_keypair = validators.voting_keypair(validator_pubkey)?;
|
|
|
|
Some(block.sign(
|
|
&voting_keypair.sk,
|
|
&fork,
|
|
self.genesis_validators_root,
|
|
&self.spec,
|
|
))
|
|
}
|
|
Ok(Safe::SameData) => {
|
|
warn!(
|
|
self.log,
|
|
"Skipping signing of previously signed block";
|
|
);
|
|
None
|
|
}
|
|
Err(NotSafe::UnregisteredValidator(pk)) => {
|
|
warn!(
|
|
self.log,
|
|
"Not signing block for unregistered validator";
|
|
"msg" => "Carefully consider running with --auto-register (see --help)",
|
|
"public_key" => format!("{:?}", pk)
|
|
);
|
|
None
|
|
}
|
|
Err(e) => {
|
|
crit!(
|
|
self.log,
|
|
"Not signing slashable block";
|
|
"error" => format!("{:?}", e)
|
|
);
|
|
None
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn sign_attestation(
|
|
&self,
|
|
validator_pubkey: &PublicKey,
|
|
validator_committee_position: usize,
|
|
attestation: &mut Attestation<E>,
|
|
current_epoch: Epoch,
|
|
) -> Option<()> {
|
|
// Make sure the target epoch is not higher than the current epoch to avoid potential attacks.
|
|
if attestation.data.target.epoch > current_epoch {
|
|
return None;
|
|
}
|
|
|
|
// Checking for slashing conditions.
|
|
let fork = self.fork()?;
|
|
|
|
let domain = self.spec.get_domain(
|
|
attestation.data.target.epoch,
|
|
Domain::BeaconAttester,
|
|
&fork,
|
|
self.genesis_validators_root,
|
|
);
|
|
let slashing_status = self.slashing_protection.check_and_insert_attestation(
|
|
validator_pubkey,
|
|
&attestation.data,
|
|
domain,
|
|
);
|
|
|
|
match slashing_status {
|
|
// We can safely sign this attestation.
|
|
Ok(Safe::Valid) => {
|
|
let validators = self.validators.read();
|
|
let voting_keypair = validators.voting_keypair(validator_pubkey)?;
|
|
|
|
attestation
|
|
.sign(
|
|
&voting_keypair.sk,
|
|
validator_committee_position,
|
|
&fork,
|
|
self.genesis_validators_root,
|
|
&self.spec,
|
|
)
|
|
.map_err(|e| {
|
|
error!(
|
|
self.log,
|
|
"Error whilst signing attestation";
|
|
"error" => format!("{:?}", e)
|
|
)
|
|
})
|
|
.ok()?;
|
|
|
|
Some(())
|
|
}
|
|
Ok(Safe::SameData) => {
|
|
warn!(
|
|
self.log,
|
|
"Skipping signing of previously signed attestation"
|
|
);
|
|
None
|
|
}
|
|
Err(NotSafe::UnregisteredValidator(pk)) => {
|
|
warn!(
|
|
self.log,
|
|
"Not signing attestation for unregistered validator";
|
|
"msg" => "Carefully consider running with --auto-register (see --help)",
|
|
"public_key" => format!("{:?}", pk)
|
|
);
|
|
None
|
|
}
|
|
Err(e) => {
|
|
crit!(
|
|
self.log,
|
|
"Not signing slashable attestation";
|
|
"attestation" => format!("{:?}", attestation.data),
|
|
"error" => format!("{:?}", e)
|
|
);
|
|
None
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Signs an `AggregateAndProof` for a given validator.
|
|
///
|
|
/// The resulting `SignedAggregateAndProof` is sent on the aggregation channel and cannot be
|
|
/// modified by actors other than the signing validator.
|
|
pub fn produce_signed_aggregate_and_proof(
|
|
&self,
|
|
validator_pubkey: &PublicKey,
|
|
validator_index: u64,
|
|
aggregate: Attestation<E>,
|
|
selection_proof: SelectionProof,
|
|
) -> Option<SignedAggregateAndProof<E>> {
|
|
let validators = self.validators.read();
|
|
let voting_keypair = &validators.voting_keypair(validator_pubkey)?;
|
|
|
|
Some(SignedAggregateAndProof::from_aggregate(
|
|
validator_index,
|
|
aggregate,
|
|
Some(selection_proof),
|
|
&voting_keypair.sk,
|
|
&self.fork()?,
|
|
self.genesis_validators_root,
|
|
&self.spec,
|
|
))
|
|
}
|
|
|
|
/// Produces a `SelectionProof` for the `slot`, signed by with corresponding secret key to
|
|
/// `validator_pubkey`.
|
|
pub fn produce_selection_proof(
|
|
&self,
|
|
validator_pubkey: &PublicKey,
|
|
slot: Slot,
|
|
) -> Option<SelectionProof> {
|
|
let validators = self.validators.read();
|
|
let voting_keypair = &validators.voting_keypair(validator_pubkey)?;
|
|
|
|
Some(SelectionProof::new::<E>(
|
|
slot,
|
|
&voting_keypair.sk,
|
|
&self.fork()?,
|
|
self.genesis_validators_root,
|
|
&self.spec,
|
|
))
|
|
}
|
|
}
|