lighthouse/validator_client/src
Kirk Baird 3db9072fee Reject invalid utf-8 characters during encryption (#1928)
## Issue Addressed

Closes #1889 

## Proposed Changes

- Error when passwords which use invalid UTF-8 characters during encryption. 
- Add some tests

## Additional Info

I've decided to error when bad characters are used to create/encrypt a keystore but think we should allow them during decryption since either the keystore was created
-  with invalid UTF-8 characters (possibly by another client or someone whose password is random bytes) in which case we'd want them to be able to decrypt their keystore using the right key.
-  without invalid characters then the password checksum would almost certainly fail.

Happy to add them to decryption if we want to make the decryption more trigger happy 😋 , it would only be a one line change and would tell the user which character index is causing the issue.

See https://eips.ethereum.org/EIPS/eip-2335#password-requirements
2020-11-19 00:37:43 +00:00
..
http_api Reject invalid utf-8 characters during encryption (#1928) 2020-11-19 00:37:43 +00:00
attestation_service.rs Update pool/attestations and committees endpoints (#1899) 2020-11-18 23:31:39 +00:00
block_service.rs Implement standard eth2.0 API (#1569) 2020-10-01 11:12:36 +10:00
cli.rs Adds colour help to bn and vc subcommands (#1811) 2020-10-23 04:16:34 +00:00
config.rs Strict slashing protection by default (#1750) 2020-10-09 02:05:32 +00:00
duties_service.rs Standard beacon api updates (#1831) 2020-11-09 23:13:56 +00:00
fork_service.rs Implement VC API (#1657) 2020-10-02 09:42:19 +00:00
initialized_validators.rs Improve validator key cache lock handling (#1837) 2020-11-09 06:03:35 +00:00
is_synced.rs Implement standard eth2.0 API (#1569) 2020-10-01 11:12:36 +10:00
key_cache.rs Implement key cache to reduce keystore loading times for validator_client (#1695) 2020-10-05 10:50:43 +00:00
lib.rs Allow VC to start without any validators (#1779) 2020-10-21 04:29:24 +00:00
notifier.rs Implement VC API (#1657) 2020-10-02 09:42:19 +00:00
validator_duty.rs Standard beacon api updates (#1831) 2020-11-09 23:13:56 +00:00
validator_store.rs Strict slashing protection by default (#1750) 2020-10-09 02:05:32 +00:00