d2e3d4c6f1
## Issue Addressed Mitigates #1096 ## Proposed Changes Add a flag to the beacon node called `--disable-lock-timeouts` which allows opting out of lock timeouts. The lock timeouts serve a dual purpose: 1. They prevent any single operation from hogging the lock for too long. When a timeout occurs it logs a nasty error which indicates that there's suboptimal lock use occurring, which we can then act on. 2. They allow deadlock detection. We're fairly sure there are no deadlocks left in Lighthouse anymore but the timeout locks offer a safeguard against that. However, timeouts on locks are not without downsides: They allow for the possibility of livelock, particularly on slower hardware. If lock timeouts keep failing spuriously the node can be prevented from making any progress, even if it would be able to make progress slowly without the timeout. One particularly concerning scenario which could occur would be if a DoS attack succeeded in slowing block signature verification times across the network, and all Lighthouse nodes got livelocked because they timed out repeatedly. This could also occur on just a subset of nodes (e.g. dual core VPSs or Raspberri Pis). By making the behaviour runtime configurable this PR allows us to choose the behaviour we want depending on circumstance. I suspect that long term we could make the timeout-free approach the default (#2381 moves in this direction) and just enable the timeouts on our testnet nodes for debugging purposes. This PR conservatively leaves the default as-is so we can gain some more experience before switching the default.
60 lines
1.9 KiB
Rust
60 lines
1.9 KiB
Rust
#![recursion_limit = "128"] // For lazy-static
|
|
pub mod attestation_verification;
|
|
mod attester_cache;
|
|
mod beacon_chain;
|
|
mod beacon_fork_choice_store;
|
|
mod beacon_proposer_cache;
|
|
mod beacon_snapshot;
|
|
mod block_times_cache;
|
|
mod block_verification;
|
|
pub mod builder;
|
|
pub mod chain_config;
|
|
mod errors;
|
|
pub mod eth1_chain;
|
|
pub mod events;
|
|
pub mod fork_revert;
|
|
mod head_tracker;
|
|
pub mod historical_blocks;
|
|
mod metrics;
|
|
pub mod migrate;
|
|
mod naive_aggregation_pool;
|
|
mod observed_aggregates;
|
|
mod observed_attesters;
|
|
mod observed_block_producers;
|
|
pub mod observed_operations;
|
|
mod persisted_beacon_chain;
|
|
mod persisted_fork_choice;
|
|
pub mod schema_change;
|
|
mod shuffling_cache;
|
|
mod snapshot_cache;
|
|
pub mod state_advance_timer;
|
|
pub mod sync_committee_verification;
|
|
pub mod test_utils;
|
|
mod timeout_rw_lock;
|
|
pub mod validator_monitor;
|
|
mod validator_pubkey_cache;
|
|
|
|
pub use self::beacon_chain::{
|
|
AttestationProcessingOutcome, BeaconChain, BeaconChainTypes, BeaconStore, ChainSegmentResult,
|
|
ForkChoiceError, StateSkipConfig, WhenSlotSkipped, MAXIMUM_GOSSIP_CLOCK_DISPARITY,
|
|
};
|
|
pub use self::beacon_snapshot::BeaconSnapshot;
|
|
pub use self::chain_config::ChainConfig;
|
|
pub use self::errors::{BeaconChainError, BlockProductionError};
|
|
pub use self::historical_blocks::HistoricalBlockError;
|
|
pub use attestation_verification::Error as AttestationError;
|
|
pub use beacon_fork_choice_store::{BeaconForkChoiceStore, Error as ForkChoiceStoreError};
|
|
pub use block_verification::{BlockError, GossipVerifiedBlock};
|
|
pub use eth1_chain::{Eth1Chain, Eth1ChainBackend};
|
|
pub use events::ServerSentEventHandler;
|
|
pub use metrics::scrape_for_metrics;
|
|
pub use parking_lot;
|
|
pub use slot_clock;
|
|
pub use state_processing::per_block_processing::errors::{
|
|
AttestationValidationError, AttesterSlashingValidationError, DepositValidationError,
|
|
ExitValidationError, ProposerSlashingValidationError,
|
|
};
|
|
pub use store;
|
|
pub use timeout_rw_lock::TimeoutRwLock;
|
|
pub use types;
|