lighthouse/beacon_node
divma 9ae9df806c Fix clippy lints rpc (#1401)
## Issue Addressed
#1388 partially (eth2_libp2p & network)

## Proposed Changes 
TLDR at the end
- *Complex types* are 3 on the handlers/Behaviours but the types are `Poll<ComplexType>` where `ComplexType` comes from the traits of libp2p. Those, I don't thing are worth an alias. A couple more were from using tokio combinators and were removed writing things the async way and using [`BoxFuture`](https://docs.rs/futures/0.3.5/futures/future/type.BoxFuture.html)
- The *cognitive complexity*.. I tried to address those before (they come from the poll functions too) and tbh they are cognitively simpler to understand the way they are now. Moving separate parts to functions doesn't add much since that code is not repeated and they all do early returns. If moved those returns would now need to be wrapped in an Option, probably, and checked to be returned again. I would leave them like that but that's just preference.
- *Too many arguments*: They are not easily put together in a wrapping struct since the parameters don't relate semantically (Ex: fn new with a log, a reference to the chain, a peer, etc) but some may differ.
- *Needless returns* were indeed needless

## Additional Info
TLDR: removed needless return, used BoxFuture and async, left the rest untouched since those lgtm
2020-07-28 01:39:42 +00:00
..
beacon_chain Add info about peer scoring to block/attestation errors (#1393) 2020-07-26 13:16:49 +10:00
client Fix clippy warnings (#1385) 2020-07-23 14:18:00 +00:00
eth1 Add info about valid deposit count to logs (#1391) 2020-07-25 04:44:10 +00:00
eth2_libp2p Fix clippy lints rpc (#1401) 2020-07-28 01:39:42 +00:00
genesis Add info about valid deposit count to logs (#1391) 2020-07-25 04:44:10 +00:00
network Fix clippy lints rpc (#1401) 2020-07-28 01:39:42 +00:00
operation_pool Support multiple BLS implementations (#1335) 2020-07-25 02:03:18 +00:00
rest_api Support multiple BLS implementations (#1335) 2020-07-25 02:03:18 +00:00
src Fix clippy warnings (#1385) 2020-07-23 14:18:00 +00:00
store Fix clippy warnings (#1385) 2020-07-23 14:18:00 +00:00
tests Improve tokio task execution (#1181) 2020-06-04 21:48:05 +10:00
timer Update deps (#1322) 2020-07-06 11:55:56 +10:00
version v0.1.2 (#1155) 2020-05-18 15:05:23 +10:00
websocket_server Improve tokio task execution (#1181) 2020-06-04 21:48:05 +10:00
Cargo.toml Add ability to configure CORS header (#1345) 2020-07-16 07:23:14 +00:00