3fdad38eba
## Issue Addressed NA ## Proposed Changes A Discord user presented logs which indicated a drop in their peer count caused by a variety of peers sending attestations where we'd already seen an attestation for that validator. It's presently unclear how this case came about, but during our investigation I noticed that we are down-voting peers for sending such attestations. There are three scenarios where we may receive duplicate unagg. attestations from the same validator: 1. The validator is committing a slashable offense. 2. The gossipsub message-deduping functionality is not working as expected. 3. We received the message via the HTTP prior to seeing it via gossip. Scenario (1) would be so costly for an attacker that I don't think we need to add DoS protection for it. Scenario (2) seems feasible. Our "seen message" caches in gossipsub might fill up/expire and let through these duplicates. There are also cases involving message ID mismatches with the other peers. In both these cases, I don't think we should be doing 1 attestation == -1 point down-voting. Scenario (3) is not necessarily a fault of the peer and we shouldn't down-score them for it. ## Additional Info NA |
||
|---|---|---|
| .. | ||
| src | ||
| Cargo.toml | ||