lighthouse/beacon_node/beacon_chain
Paul Hauner 1f54e10b7b Do not interpret "latest valid hash" as identifying a valid hash (#3327)
## Issue Addressed

NA

## Proposed Changes

After some discussion in Discord with @mkalinin it was raised that it was not the intention of the engine API to have CLs validate the `latest_valid_hash` (LVH) and all ancestors.

Whilst I believe the engine API is being updated such that the LVH *must* identify a valid hash or be set to some junk value, I'm not confident that we can rely upon the LVH as being valid (at least for now) due to the confusion surrounding it.

Being able to validate blocks via the LVH is a relatively minor optimisation; if the LVH value ends up becoming our head we'll send an fcU and get the VALID status there.

Falsely marking a block as valid has serious consequences and since it's a minor optimisation to use LVH I think that we don't take the risk.

For clarity, we will still *invalidate* the *descendants* of the LVH, we just wont *validate* the *ancestors*.

## Additional Info

NA
2022-07-13 23:07:49 +00:00
..
src Use async code when interacting with EL (#3244) 2022-07-03 05:36:50 +00:00
tests Do not interpret "latest valid hash" as identifying a valid hash (#3327) 2022-07-13 23:07:49 +00:00
Cargo.toml Allow TaskExecutor to be used in async tests (#3178) 2022-05-16 08:35:59 +00:00